chore: code review changes

rudderlabs · Sep 26, 2023 · fe15ecc · fe15ecc
1 parent c619099
commit fe15ecc
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/src/v0/destinations/intercom/deleteUsers.js b/src/v0/destinations/intercom/deleteUsers.js
@@ -12,9 +12,9 @@ const userDeletionHandler = async (userAttributes, config) => {
   if (!config) {
     throw new ConfigurationError('Config for deletion not present');
   }
-  const { apiKey } = config;
-  if (!apiKey) {
-    throw new ConfigurationError('api key for deletion not present');
+  const { accessToken } = config;
+  if (!accessToken) {
+    throw new ConfigurationError('access token for deletion not present');
   }
   const validUserIds = [];
   userAttributes.forEach((userAttribute) => {
@@ -31,7 +31,7 @@ const userDeletionHandler = async (userAttributes, config) => {
       };
       const requestOptions = {
         headers: {
-          Authorization: `Bearer ${apiKey}`,
+          Authorization: `Bearer ${accessToken}`,
           Accept: JSON_MIME_TYPE,
         },
       };

diff --git a/src/v0/destinations/intercom/util.js b/src/v0/destinations/intercom/util.js
@@ -58,7 +58,7 @@ const validateTrack = (payload) => {
  */
 const getHeaders = (destination) => ({
   'Content-Type': JSON_MIME_TYPE,
-  Authorization: `Bearer ${destination.Config.apiKey}`,
+  Authorization: `Bearer ${destination.Config.accessToken}`,
   Accept: JSON_MIME_TYPE,
   'Intercom-Version': '2.10',
 });

diff --git a/test/__tests__/data/intercom.json b/test/__tests__/data/intercom.json
@@ -20,7 +20,7 @@
       },
       "destination": {
         "Config": {
-          "apiKey": "ABC..."
+          "accessToken": "ABC..."
         }
       },
       "metadata": {
@@ -55,7 +55,7 @@
       },
       "destination": {
         "Config": {
-          "apiKey": "ABC..."
+          "accessToken": "ABC..."
         }
       }
     },
@@ -84,7 +84,7 @@
       },
       "destination": {
         "Config": {
-          "apiKey": "ABC..."
+          "accessToken": "ABC..."
         }
       }
     },
@@ -160,7 +160,7 @@
       },
       "destination": {
         "Config": {
-          "apiKey": "dummyApiKey",
+          "accessToken": "dummyaccessToken",
           "apiServer": "standard"
         }
       }
@@ -192,7 +192,7 @@
       "files": {},
       "headers": {
         "Accept": "application/json",
-        "Authorization": "Bearer dummyApiKey",
+        "Authorization": "Bearer dummyaccessToken",
         "Content-Type": "application/json",
         "Intercom-Version": "2.10"
       },
@@ -267,7 +267,7 @@
       },
       "destination": {
         "Config": {
-          "apiKey": "dummyApiKey",
+          "accessToken": "dummyaccessToken",
           "apiServer": "standard",
           "sendAnonymousId": true
         }
@@ -300,7 +300,7 @@
       "files": {},
       "headers": {
         "Accept": "application/json",
-        "Authorization": "Bearer dummyApiKey",
+        "Authorization": "Bearer dummyaccessToken",
         "Content-Type": "application/json",
         "Intercom-Version": "2.10"
       },
@@ -384,7 +384,7 @@
       },
       "destination": {
         "Config": {
-          "apiKey": "dummyApiKey",
+          "accessToken": "dummyaccessToken",
           "apiServer": "eu",
           "sendAnonymousId": true
         }
@@ -469,7 +469,7 @@
       },
       "destination": {
         "Config": {
-          "apiKey": "dummyApiKey",
+          "accessToken": "dummyaccessToken",
           "apiServer": "au",
           "sendAnonymousId": true
         }
@@ -501,7 +501,7 @@
       "files": {},
       "headers": {
         "Accept": "application/json",
-        "Authorization": "Bearer dummyApiKey",
+        "Authorization": "Bearer dummyaccessToken",
         "Content-Type": "application/json",
         "Intercom-Version": "2.10"
       },
@@ -537,7 +537,7 @@
       },
       "destination": {
         "Config": {
-          "apiKey": "dummyApiKey",
+          "accessToken": "dummyaccessToken",
           "apiServer": "standard",
           "sendAnonymousId": true
         }
@@ -556,7 +556,7 @@
       "files": {},
       "headers": {
         "Accept": "application/json",
-        "Authorization": "Bearer dummyApiKey",
+        "Authorization": "Bearer dummyaccessToken",
         "Content-Type": "application/json",
         "Intercom-Version": "2.10"
       },