Merge branch 'develop' into feat.hs-batching

.github/workflows/component-test-report.yml

@@ -0,0 +1,68 @@
+name: Component Test Reporter
+
+on:
+  pull_request:
+    types:
+      - opened
+      - reopened
+      - synchronize
+
+permissions:
+  id-token: write # allows the JWT to be requested from GitHub's OIDC provider
+  contents: read # This is required for actions/checkout
+
+jobs:
+  test_and_upload:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Configure AWS Credentials
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          role-to-assume: arn:aws:iam::${{ secrets.AWS_DEV_ACCOUNT_ID }}:role/${{ secrets.AWS_DEV_S3_SYNC_ROLE }}
+          aws-region: us-east-1
+
+      - name: Checkout
+        uses: actions/[email protected]
+        with:
+          fetch-depth: 1
+
+      - name: Setup Node
+        uses: actions/[email protected]
+        with:
+          node-version-file: '.nvmrc'
+          cache: 'npm'
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Run Tests and Generate Report
+        run: |
+          npm run test:ts -- component
+
+
+      - name: Uplaod Report to S3
+        run: |
+          aws s3 cp ./test_reports/ s3://test-integrations-dev/integrations-test-reports/rudder-transformer/${{ github.event.number }}/ --recursive
+
+    
+      - name: Comment on PR with S3 Object URL
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.PAT }}
+          script: |
+            const { owner, repo } = context.repo;
+            // Get the pull request number
+            const prNumber = context.payload.pull_request.number;
+            const commentBody = `Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/${prNumber}/test-report.html`;
+            
+
+            // Comment on the pull request
+            github.rest.issues.createComment({
+              owner,
+              repo,
+              issue_number: prNumber,
+              body: commentBody
+            });
+
+        

.github/workflows/prepare-for-dev-deploy.yml

@@ -14,7 +14,7 @@ jobs:
   report-coverage:
     name: Report Code Coverage
     if: github.event_name == 'push'
-    uses: ./.github/workflows/report-code-coverage.yml
+    uses: ./.github/workflows/dt-test-and-report-code-coverage.yml
     secrets:
       SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 

.github/workflows/prepare-for-prod-dt-deploy.yml

@@ -14,7 +14,7 @@ jobs:
   report-coverage:
     name: Report Code Coverage
     if: github.event_name == 'push'
-    uses: ./.github/workflows/report-code-coverage.yml
+    uses: ./.github/workflows/dt-test-and-report-code-coverage.yml
     secrets:
       SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 

.github/workflows/prepare-for-prod-ut-deploy.yml

@@ -14,7 +14,7 @@ jobs:
   report-coverage:
     name: Report Code Coverage
     if: github.event_name == 'push'
-    uses: ./.github/workflows/report-code-coverage.yml
+    uses: ./.github/workflows/dt-test-and-report-code-coverage.yml
     secrets:
       SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 

.github/workflows/ut-tests.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Setup Go
-        uses: actions/setup-go@v4.1.0
+        uses: actions/setup-go@v5.0.0
         with:
           go-version: 1.17
 

.gitignore

@@ -134,4 +134,7 @@ dist
 **/.DS_Store
 
 
-.idea
+.idea
+
+# component test report
+test_reports/

package.json

@@ -110,7 +110,7 @@
     "stacktrace-parser": "^0.1.10",
     "statsd-client": "^0.4.7",
     "truncate-utf8-bytes": "^1.0.2",
-    "ua-parser-js": "^1.0.35",
+    "ua-parser-js": "^1.0.37",
     "unset-value": "^2.0.1",
     "uuid": "^9.0.0",
     "valid-url": "^1.0.9"

src/cdk/v2/destinations/ortto/procWorkflow.yaml

@@ -34,6 +34,7 @@ steps:
     description: |
       Builds common fields in destination payload.
     template: |
+      let phone = .message.().({{{{$.getGenericPaths("phone")}}}});
       let commonFields = .message.().({
         "fields": { 
           "str::first": {{{{$.getGenericPaths("firstName")}}}}, 
@@ -46,7 +47,7 @@ steps:
           "dtz::b": $.getBirthdayObj({{{{$.getGenericPaths("birthday")}}}}),
           "str::ei": {{{{$.getGenericPaths("userId")}}}},
           "str::language": .context.traits.language || .context.locale,
-          "phn::phone": {"n": {{{{$.getGenericPaths("phone")}}}}},
+          "phn::phone": phone ? {"n": phone},
           "bol::gdpr": .context.traits.gdpr ?? true,
           "bol::p": .context.traits.emailConsent || false,
           "bol::sp": .context.traits.smsConsent || false,

src/cdk/v2/destinations/the_trade_desk/utils.js

@@ -8,6 +8,7 @@ const {
   getSuccessRespEvents,
   removeUndefinedAndNullValues,
   handleRtTfSingleEventError,
+  isEmptyObject,
 } = require('../../../../v0/util');
 const tradeDeskConfig = require('./config');
 
@@ -59,34 +60,44 @@ const processRecordInputs = (inputs, destination) => {
   const successMetadata = [];
   const errorResponseList = [];
 
-  const error = new InstrumentationError('Invalid action type');
+  const invalidActionTypeError = new InstrumentationError('Invalid action type');
+  const emptyFieldsError = new InstrumentationError('Fields cannot be empty');
 
   inputs.forEach((input) => {
     const { fields, action } = input.message;
     const isInsertOrDelete = action === 'insert' || action === 'delete';
 
-    if (isInsertOrDelete) {
-      successMetadata.push(input.metadata);
-      const data = [
-        {
-          Name: Config.audienceId,
-          TTLInMinutes: action === 'insert' ? ttlInMin(Config.ttlInDays) : 0,
-        },
-      ];
-
-      Object.keys(fields).forEach((id) => {
-        const value = fields[id];
-        if (value) {
-          // adding only non empty ID's
-          items.push({ [id]: value, Data: data });
-        }
-      });
-    } else {
-      errorResponseList.push(handleRtTfSingleEventError(input, error, {}));
+    if (!isInsertOrDelete) {
+      errorResponseList.push(handleRtTfSingleEventError(input, invalidActionTypeError, {}));
+      return;
     }
+
+    if (isEmptyObject(fields)) {
+      errorResponseList.push(handleRtTfSingleEventError(input, emptyFieldsError, {}));
+      return;
+    }
+
+    successMetadata.push(input.metadata);
+    const data = [
+      {
+        Name: Config.audienceId,
+        TTLInMinutes: action === 'insert' ? ttlInMin(Config.ttlInDays) : 0,
+      },
+    ];
+
+    Object.keys(fields).forEach((id) => {
+      const value = fields[id];
+      if (value) {
+        // adding only non empty ID's
+        items.push({ [id]: value, Data: data });
+      }
+    });
   });
 
   const payloads = batchResponseBuilder(items, Config);
+  if (payloads.length === 0) {
+    return errorResponseList;
+  }
 
   const response = getSuccessRespEvents(payloads, successMetadata, destination, true);
   return [response, ...errorResponseList];