Skip to content

Commit

Permalink
chore: test pr failure if linting are skiiped locally
Browse files Browse the repository at this point in the history
  • Loading branch information
aashishmalik committed Sep 29, 2023
1 parent b784800 commit e91e1d7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/v0/destinations/mp/transform.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ const responseBuilderSimple = (payload, message, eventType, destConfig) => {
}
break;
case 'merge':
// eslint-disable-next-line no-case-declarations
const credentials = setImportCredentials(destConfig);

Check failure on line 99 in src/v0/destinations/mp/transform.js

View workflow job for this annotation

GitHub Actions / Code Coverage

Unexpected lexical declaration in case block
response.endpoint = credentials.endpoint;
response.headers = credentials.headers;
Expand Down
1 change: 0 additions & 1 deletion src/v0/destinations/mp/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ const isImportAuthCredentialsAvailable = (destination) =>
const findExistingBatch = (batch, metadataMap) => {
let existingBatch = null;

// eslint-disable-next-line no-restricted-syntax
for (const metadataItem of batch.metadata) {

Check failure on line 146 in src/v0/destinations/mp/util.js

View workflow job for this annotation

GitHub Actions / Code Coverage

iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations
if (metadataMap.has(metadataItem.jobId)) {
existingBatch = metadataMap.get(metadataItem.jobId);
Expand Down

0 comments on commit e91e1d7

Please sign in to comment.