fix: heap: make userId as required for track and idenitfy call

rudderlabs · Mar 20, 2024 · da16a9e · da16a9e
1 parent c5cc69b
commit da16a9e
Show file tree

Hide file tree

Showing 2 changed files with 104 additions and 1 deletion.
diff --git a/src/cdk/v2/destinations/heap/procWorkflow.yaml b/src/cdk/v2/destinations/heap/procWorkflow.yaml
@@ -40,7 +40,9 @@ steps:
       });
       .message.properties.idempotencyKey ? 
         ($.context.payload.idempotency_key = .message.properties.idempotencyKey);
-
+  - name: validateuserId
+    template: |
+      $.assert($.context.payload.identity, "userId is required");
   - name: finalPayload
     description: In batchMode we return payload directly
     condition: $.batchMode

diff --git a/test/integrations/destinations/heap/processor/data.ts b/test/integrations/destinations/heap/processor/data.ts
@@ -961,4 +961,105 @@ export const data = [
       },
     },
   },
+  {
+    name: 'heap',
+    description: 'Test 8 -> Identify: No userId is present',
+    feature: 'processor',
+    module: 'destination',
+    version: 'v0',
+    input: {
+      request: {
+        body: [
+          {
+            destination: {
+              Config: {
+                appId: '<app id>',
+              },
+              DestinationDefinition: {
+                Config: {
+                  cdkV2Enabled: true,
+                },
+                DisplayName: 'Heap.io',
+                ID: '1WTbl0l5GjOQKOvfmcGwk0T49kV',
+                Name: 'HEAP',
+              },
+              Enabled: true,
+              ID: '1WTcDSEOE437e4ePH10BJNELXmE',
+              Name: 'heap test',
+              Transformations: [],
+            },
+            metadata: {
+              destinationId: 'destId',
+              workspaceId: 'wspId',
+            },
+            message: {
+              channel: 'web',
+              context: {
+                app: {
+                  build: '1.0.0',
+                  name: 'RudderLabs JavaScript SDK',
+                  namespace: 'com.rudderlabs.javascript',
+                  version: '1.0.0',
+                },
+                ip: '0.0.0.0',
+                library: {
+                  name: 'RudderLabs JavaScript SDK',
+                  version: '1.0.0',
+                },
+                locale: 'en-US',
+                os: {
+                  name: '',
+                  version: '',
+                },
+                screen: {
+                  density: 2,
+                },
+                userAgent:
+                  'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36',
+              },
+              integrations: {
+                All: true,
+              },
+              traits: {
+                email: '[email protected]',
+              },
+              messageId: 'fca2e71a-5d30-48e1-ba45-761c16e3820f',
+              originalTimestamp: '2020-01-16T13:21:59.076Z',
+              receivedAt: '2020-01-16T18:52:03.871+05:30',
+              request_ip: '[::1]:62312',
+              sentAt: '2020-01-16T13:22:03.85Z',
+              timestamp: '2020-01-16T18:51:59.097+05:30',
+              type: 'identify',
+            },
+          },
+        ],
+      },
+    },
+    output: {
+      response: {
+        status: 200,
+        body: [
+          {
+            error:
+              'userId is required: Workflow: procWorkflow, Step: validateuserId, ChildStep: undefined, OriginalError: userId is required',
+            statTags: {
+              destinationId: 'destId',
+              workspaceId: 'wspId',
+              destType: 'HEAP',
+              errorCategory: 'dataValidation',
+              errorType: 'instrumentation',
+              feature: 'processor',
+              implementation: 'cdkV2',
+              module: 'destination',
+            },
+            statusCode: 400,
+            metadata: {
+              destinationId: 'destId',
+              workspaceId: 'wspId',
+            },
+          },
+        ],
+      },
+    },
+  },
 ];