fix: decoupling networkHandler and specific strategy

rudderlabs · Nov 20, 2024 · c87c5ce · c87c5ce
1 parent 25a5ced
commit c87c5ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/v1/destinations/iterable/networkHandler.js b/src/v1/destinations/iterable/networkHandler.js
@@ -1,15 +1,12 @@
 const { prepareProxyRequest, proxyRequest } = require('../../../adapters/network');
 const { processAxiosResponse } = require('../../../adapters/utils/networkUtils');
 const { BULK_ENDPOINTS } = require('../../../v0/destinations/iterable/config');
-const {
-  checkIfEventIsAbortableAndExtractErrorMessage,
-} = require('../../../v0/destinations/iterable/util');
 const { CommonStrategy } = require('./commonStrategy');
 const { TrackIdentifyStrategy } = require('./trackIdentifyStrategy');
 
 const getResponseStrategy = (endpoint) => {
   if (BULK_ENDPOINTS.some((path) => endpoint.includes(path))) {
-    return new TrackIdentifyStrategy(checkIfEventIsAbortableAndExtractErrorMessage);
+    return new TrackIdentifyStrategy();
   }
   return new CommonStrategy();
 };

diff --git a/src/v1/destinations/iterable/trackIdentifyStrategy.js b/src/v1/destinations/iterable/trackIdentifyStrategy.js
@@ -1,9 +1,12 @@
 const { ResponseStrategy } = require('./responseStrategy');
+const {
+  checkIfEventIsAbortableAndExtractErrorMessage,
+} = require('../../../v0/destinations/iterable/util');
 
 class TrackIdentifyStrategy extends ResponseStrategy {
-  constructor(filterFn) {
+  constructor() {
     super();
-    this.filterFn = filterFn;
+    this.filterFn = checkIfEventIsAbortableAndExtractErrorMessage;
   }
 
   handleSuccess(responseParams) {