refactor: deprecate mixpanel /track endpoint

rudderlabs · Nov 16, 2023 · c3e22d6 · c3e22d6
1 parent ff80b88
commit c3e22d6
Show file tree

Hide file tree

Showing 7 changed files with 245 additions and 234 deletions.
diff --git a/src/v0/destinations/mp/config.js b/src/v0/destinations/mp/config.js
@@ -46,7 +46,6 @@ const MP_IDENTIFY_EXCLUSION_LIST = [
 ];
 
 const GEO_SOURCE_ALLOWED_VALUES = [null, 'reverse_geocoding'];
-const TRACK_MAX_BATCH_SIZE = 50;
 const IMPORT_MAX_BATCH_SIZE = 2000;
 const ENGAGE_MAX_BATCH_SIZE = 2000;
 const GROUPS_MAX_BATCH_SIZE = 200;
@@ -65,7 +64,6 @@ module.exports = {
   MP_IDENTIFY_EXCLUSION_LIST,
   getCreateDeletionTaskEndpoint,
   DISTINCT_ID_MAX_BATCH_SIZE,
-  TRACK_MAX_BATCH_SIZE,
   IMPORT_MAX_BATCH_SIZE,
   ENGAGE_MAX_BATCH_SIZE,
   GROUPS_MAX_BATCH_SIZE,

diff --git a/src/v0/destinations/mp/transform.js b/src/v0/destinations/mp/transform.js
@@ -24,7 +24,6 @@ const {
   BASE_ENDPOINT,
   BASE_ENDPOINT_EU,
   IMPORT_MAX_BATCH_SIZE,
-  TRACK_MAX_BATCH_SIZE,
   ENGAGE_MAX_BATCH_SIZE,
   GROUPS_MAX_BATCH_SIZE,
 } = require('./config');
@@ -44,21 +43,19 @@ const mPEventPropertiesConfigJson = mappingConfig[ConfigCategory.EVENT_PROPERTIE
 const setImportCredentials = (destConfig) => {
   const endpoint =
     destConfig.dataResidency === 'eu' ? `${BASE_ENDPOINT_EU}/import/` : `${BASE_ENDPOINT}/import/`;
-  const headers = { 'Content-Type': 'application/json' };
   const params = { strict: destConfig.strictMode ? 1 : 0 };
-  const { apiSecret, serviceAccountUserName, serviceAccountSecret, projectId } = destConfig;
-  if (apiSecret) {
-    headers.Authorization = `Basic ${base64Convertor(`${apiSecret}:`)}`;
-  } else if (serviceAccountUserName && serviceAccountSecret && projectId) {
-    headers.Authorization = `Basic ${base64Convertor(
-      `${serviceAccountUserName}:${serviceAccountSecret}`,
-    )}`;
+  const { serviceAccountUserName, serviceAccountSecret, projectId, token } = destConfig;
+  let credentials;
+  if (serviceAccountUserName && serviceAccountSecret && projectId) {
+    credentials = `${serviceAccountUserName}:${serviceAccountSecret}`;
     params.projectId = projectId;
   } else {
-    throw new InstrumentationError(
-      'Event timestamp is older than 5 days and no API secret or service account credentials (i.e. username, secret and projectId) are provided in destination configuration',
-    );
+    credentials = `${token}:`;
   }
+  const headers = {
+    'Content-Type': 'application/json',
+    Authorization: `Basic ${base64Convertor(credentials)}`,
+  };
   return { endpoint, headers, params };
 };
 
@@ -67,35 +64,25 @@ const responseBuilderSimple = (payload, message, eventType, destConfig) => {
   response.method = defaultPostRequestConfig.requestMethod;
   response.userId = message.userId || message.anonymousId;
   response.body.JSON_ARRAY = { batch: JSON.stringify([removeUndefinedValues(payload)]) };
-  const { apiSecret, serviceAccountUserName, serviceAccountSecret, projectId, dataResidency } =
-    destConfig;
+  const { dataResidency } = destConfig;
   const duration = getTimeDifference(message.timestamp);
   switch (eventType) {
     case EventType.ALIAS:
     case EventType.TRACK:
     case EventType.SCREEN:
-    case EventType.PAGE:
-      if (
-        !apiSecret &&
-        !(serviceAccountUserName && serviceAccountSecret && projectId) &&
-        duration.days <= 5
-      ) {
-        response.endpoint =
-          dataResidency === 'eu' ? `${BASE_ENDPOINT_EU}/track/` : `${BASE_ENDPOINT}/track/`;
-        response.headers = {};
-      } else if (duration.years > 5) {
+    case EventType.PAGE: {
+      if (duration.years > 5) {
         throw new InstrumentationError('Event timestamp should be within last 5 years');
-      } else {
-        const credentials = setImportCredentials(destConfig);
-        response.endpoint = credentials.endpoint;
-        response.headers = credentials.headers;
-        response.params = {
-          project_id: credentials.params?.projectId,
-          strict: credentials.params.strict,
-        };
-        break;
       }
+      const credentials = setImportCredentials(destConfig);
+      response.endpoint = credentials.endpoint;
+      response.headers = credentials.headers;
+      response.params = {
+        project_id: credentials.params?.projectId,
+        strict: credentials.params.strict,
+      };
       break;
+    }
     case 'merge':
       // eslint-disable-next-line no-case-declarations
       const credentials = setImportCredentials(destConfig);
@@ -455,19 +442,13 @@ const processRouterDest = async (inputs, reqMetadata) => {
       );
 
       transformedPayloads = lodash.flatMap(transformedPayloads);
-      const { engageEvents, groupsEvents, trackEvents, importEvents, batchErrorRespList } =
+      const { engageEvents, groupsEvents, importEvents, batchErrorRespList } =
         groupEventsByEndpoint(transformedPayloads);
 
       const engageRespList = batchEvents(engageEvents, ENGAGE_MAX_BATCH_SIZE, reqMetadata);
       const groupsRespList = batchEvents(groupsEvents, GROUPS_MAX_BATCH_SIZE, reqMetadata);
-      const trackRespList = batchEvents(trackEvents, TRACK_MAX_BATCH_SIZE, reqMetadata);
       const importRespList = batchEvents(importEvents, IMPORT_MAX_BATCH_SIZE, reqMetadata);
-      const batchSuccessRespList = [
-        ...engageRespList,
-        ...groupsRespList,
-        ...trackRespList,
-        ...importRespList,
-      ];
+      const batchSuccessRespList = [...engageRespList, ...groupsRespList, ...importRespList];
 
       return [...batchSuccessRespList, ...batchErrorRespList];
     }),

diff --git a/src/v0/destinations/mp/util.js b/src/v0/destinations/mp/util.js
@@ -212,7 +212,6 @@ const groupEventsByEndpoint = (events) => {
   const eventMap = {
     engage: [],
     groups: [],
-    track: [],
     import: [],
   };
   const batchErrorRespList = [];
@@ -237,7 +236,6 @@ const groupEventsByEndpoint = (events) => {
   return {
     engageEvents: eventMap.engage,
     groupsEvents: eventMap.groups,
-    trackEvents: eventMap.track,
     importEvents: eventMap.import,
     batchErrorRespList,
   };

diff --git a/src/v0/destinations/mp/util.test.js b/src/v0/destinations/mp/util.test.js
@@ -35,7 +35,6 @@ describe('Mixpanel utils test', () => {
       expect(result).toEqual({
         engageEvents: [],
         groupsEvents: [],
-        trackEvents: [],
         importEvents: [],
         batchErrorRespList: [],
       });
@@ -78,7 +77,7 @@ describe('Mixpanel utils test', () => {
         },
         {
           message: {
-            endpoint: '/track',
+            endpoint: '/import',
             body: {
               JSON_ARRAY: {
                 batch: '[{prop:4}]',
@@ -139,10 +138,10 @@ describe('Mixpanel utils test', () => {
             },
           },
         ],
-        trackEvents: [
+        importEvents: [
           {
             message: {
-              endpoint: '/track',
+              endpoint: '/import',
               body: {
                 JSON_ARRAY: {
                   batch: '[{prop:4}]',
@@ -151,8 +150,6 @@ describe('Mixpanel utils test', () => {
               userId: 'user1',
             },
           },
-        ],
-        importEvents: [
           {
             message: {
               endpoint: '/import',
@@ -267,7 +264,7 @@ describe('Mixpanel utils test', () => {
       const input = [
         {
           batchedRequest: {
-            endpoint: 'https://api.mixpanel.com/track/',
+            endpoint: 'https://api.mixpanel.com/import/',
           },
           metadata: [
             {
@@ -294,19 +291,6 @@ describe('Mixpanel utils test', () => {
           statusCode: 200,
           destination: destinationMock,
         },
-        {
-          batchedRequest: {
-            endpoint: 'https://api.mixpanel.com/track/',
-          },
-          metadata: [
-            {
-              jobId: 5,
-            },
-          ],
-          batched: true,
-          statusCode: 200,
-          destination: destinationMock,
-        },
         {
           batchedRequest: {
             endpoint: 'https://api.mixpanel.com/engage/',
@@ -342,7 +326,7 @@ describe('Mixpanel utils test', () => {
         {
           batchedRequest: [
             {
-              endpoint: 'https://api.mixpanel.com/track/',
+              endpoint: 'https://api.mixpanel.com/import/',
             },
             {
               endpoint: 'https://api.mixpanel.com/engage/',
@@ -366,19 +350,6 @@ describe('Mixpanel utils test', () => {
           statusCode: 200,
           destination: destinationMock,
         },
-        {
-          batchedRequest: {
-            endpoint: 'https://api.mixpanel.com/track/',
-          },
-          metadata: [
-            {
-              jobId: 5,
-            },
-          ],
-          batched: true,
-          statusCode: 200,
-          destination: destinationMock,
-        },
         {
           batchedRequest: {
             endpoint: 'https://api.mixpanel.com/import/',
@@ -400,7 +371,7 @@ describe('Mixpanel utils test', () => {
       const input = [
         {
           batchedRequest: {
-            endpoint: 'https://api.mixpanel.com/track/',
+            endpoint: 'https://api.mixpanel.com/import/',
           },
           metadata: [
             {
@@ -445,7 +416,7 @@ describe('Mixpanel utils test', () => {
       const expectedOutput = [
         {
           batchedRequest: {
-            endpoint: 'https://api.mixpanel.com/track/',
+            endpoint: 'https://api.mixpanel.com/import/',
           },
 
           metadata: [

diff --git a/test/integrations/destinations/mp/common.ts b/test/integrations/destinations/mp/common.ts
@@ -5,7 +5,7 @@ const defaultMockFns = () => {
 const sampleDestination = {
   Config: {
     apiKey: 'dummyApiKey',
-    token: 'dummyApiKey',
+    token: 'test_api_token',
     prefixProperties: true,
     useNativeSDK: false,
   },