chore: minor refactor

rudderlabs · Jun 11, 2024 · bb3d938 · bb3d938
1 parent 696352d
commit bb3d938
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 35 deletions.
diff --git a/src/v0/destinations/ga4/transform.js b/src/v0/destinations/ga4/transform.js
@@ -1,9 +1,5 @@
 const get = require('get-value');
-const {
-  ConfigurationError,
-  InstrumentationError,
-  UnsupportedEventError,
-} = require('@rudderstack/integrations-lib');
+const { InstrumentationError, UnsupportedEventError } = require('@rudderstack/integrations-lib');
 const { EventType } = require('../../../constants');
 const {
   isEmptyObject,
@@ -33,6 +29,7 @@ const {
   basicValidation,
   addClientDetails,
   buildDeliverablePayload,
+  basicConfigvalidaiton,
 } = require('./utils');
 require('../../util/constant');
 
@@ -204,23 +201,12 @@ const process = (event) => {
   const { message, destination } = event;
   const { Config } = destination;
 
-  if (!Config.typesOfClient) {
-    throw new ConfigurationError('Client type not found. Aborting ');
-  }
-  if (!Config.apiSecret) {
-    throw new ConfigurationError('API Secret not found. Aborting ');
-  }
-  if (Config.typesOfClient === 'gtag' && !Config.measurementId) {
-    throw new ConfigurationError('measurementId must be provided. Aborting');
-  }
-  if (Config.typesOfClient === 'firebase' && !Config.firebaseAppId) {
-    throw new ConfigurationError('firebaseAppId must be provided. Aborting');
-  }
-
   if (!message.type) {
     throw new InstrumentationError('Message Type is not present. Aborting message.');
   }
 
+  basicConfigvalidaiton(Config);
+
   const messageType = message.type.toLowerCase();
 
   let response;

diff --git a/src/v0/destinations/ga4/utils.js b/src/v0/destinations/ga4/utils.js
@@ -570,10 +570,26 @@ const sanitizeUserProperties = (userProperties) => {
   });
 };
 
+const basicConfigvalidaiton = (Config) => {
+  if (!Config.typesOfClient) {
+    throw new ConfigurationError('Client type not found. Aborting ');
+  }
+  if (!Config.apiSecret) {
+    throw new ConfigurationError('API Secret not found. Aborting ');
+  }
+  if (Config.typesOfClient === 'gtag' && !Config.measurementId) {
+    throw new ConfigurationError('measurementId must be provided. Aborting');
+  }
+  if (Config.typesOfClient === 'firebase' && !Config.firebaseAppId) {
+    throw new ConfigurationError('firebaseAppId must be provided. Aborting');
+  }
+};
+
 module.exports = {
   addClientDetails,
   basicValidation,
   buildDeliverablePayload,
+  basicConfigvalidaiton,
   getItem,
   getItemList,
   getItemsArray,

diff --git a/src/v0/destinations/ga4_v2/transform.ts b/src/v0/destinations/ga4_v2/transform.ts
@@ -1,28 +1,14 @@
-import {
-  ConfigurationError,
-  InstrumentationError,
-  RudderStackEvent,
-} from '@rudderstack/integrations-lib';
+import { InstrumentationError, RudderStackEvent } from '@rudderstack/integrations-lib';
 import { ProcessorTransformationRequest } from '../../../types';
 import { handleCustomMappings } from './customMappingsHandler';
 import { process as ga4Process } from '../ga4/transform';
+import { basicConfigvalidaiton } from '../ga4/utils';
 
 export function process(event: ProcessorTransformationRequest) {
   const { message, destination } = event;
   const { Config } = destination;
 
-  if (!Config.typesOfClient) {
-    throw new ConfigurationError('Client type not found. Aborting ');
-  }
-  if (!Config.apiSecret) {
-    throw new ConfigurationError('API Secret not found. Aborting ');
-  }
-  if (Config.typesOfClient === 'gtag' && !Config.measurementId) {
-    throw new ConfigurationError('measurementId must be provided. Aborting');
-  }
-  if (Config.typesOfClient === 'firebase' && !Config.firebaseAppId) {
-    throw new ConfigurationError('firebaseAppId must be provided. Aborting');
-  }
+  basicConfigvalidaiton(Config);
 
   const eventPayload = message as RudderStackEvent;