fix: adding more test cases

rudderlabs · Jan 25, 2024 · ba24539 · ba24539
1 parent ebf6428
commit ba24539
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 3 deletions.
diff --git a/src/v0/destinations/marketo_bulk_upload/util.js b/src/v0/destinations/marketo_bulk_upload/util.js
@@ -3,6 +3,7 @@ const {
   RetryableError,
   NetworkError,
   TransformationError,
+  isDefinedAndNotNull,
 } = require('@rudderstack/integrations-lib');
 const { handleHttpRequest } = require('../../../adapters/network');
 const tags = require('../../util/tags');
@@ -130,9 +131,12 @@ const getAccessToken = async (config) => {
   });
 
   // sample response : {response: '[ENOTFOUND] :: DNS lookup failed', status: 400}
-  if (!isHttpStatusSuccess(accessTokenResponse.status)) {
+  if (
+    isDefinedAndNotNull(accessTokenResponse.status) &&
+    !isHttpStatusSuccess(accessTokenResponse.status)
+  ) {
     throw new NetworkError(
-      `Could not retrieve authorisation token due to error ${accessTokenResponse}`,
+      `Could not retrieve authorisation token due to error ${JSON.stringify(accessTokenResponse)}`,
       hydrateStatusForServer(accessTokenResponse.status, FETCH_ACCESS_TOKEN),
       {
         [tags.TAG_NAMES.ERROR_TYPE]: getDynamicErrorType(accessTokenResponse.status),

diff --git a/src/v0/destinations/marketo_bulk_upload/util.test.js b/src/v0/destinations/marketo_bulk_upload/util.test.js
@@ -1,7 +1,7 @@
 const util = require('./util.js');
-const axios = require('axios');
 const networkAdapter = require('../../../adapters/network');
 const { handleHttpRequest } = networkAdapter;
+const { AbortedError, RetryableError, NetworkError } = require('@rudderstack/integrations-lib');
 
 // Mock the handleHttpRequest function
 jest.mock('../../../adapters/network');
@@ -61,4 +61,59 @@ describe('util.getAccessToken', () => {
       feature: 'transformation',
     });
   });
+
+  it('should throw a NetworkError on unsuccessful HTTP status', async () => {
+    handleHttpRequest.mockResolvedValueOnce({
+      processedResponse: unsuccessfulResponse,
+    });
+
+    const config = {
+      clientId: 'dummyClientId',
+      clientSecret: 'dummyClientSecret',
+      munchkinId: 'dummyMunchkinId',
+    };
+
+    await expect(util.getAccessToken(config)).rejects.toThrow(NetworkError);
+  });
+
+  it('should throw a RetryableError when expires_in is 0', async () => {
+    handleHttpRequest.mockResolvedValueOnce({
+      processedResponse: {
+        ...successfulResponse,
+        response: { ...successfulResponse.response, expires_in: 0 },
+      },
+    });
+
+    const config = {
+      clientId: 'dummyClientId',
+      clientSecret: 'dummyClientSecret',
+      munchkinId: 'dummyMunchkinId',
+    };
+
+    await expect(util.getAccessToken(config)).rejects.toThrow(RetryableError);
+  });
+
+  it('should throw an AbortedError on unsuccessful response', async () => {
+    handleHttpRequest.mockResolvedValueOnce({ processedResponse: invalidClientErrorResponse });
+
+    const config = {
+      clientId: 'invalidClientID',
+      clientSecret: 'dummyClientSecret',
+      munchkinId: 'dummyMunchkinId',
+    };
+
+    await expect(util.getAccessToken(config)).rejects.toThrow(NetworkError);
+  });
+
+  it('should throw abortable error response', async () => {
+    handleHttpRequest.mockResolvedValueOnce({ processedResponse: emptyResponse });
+
+    const config = {
+      clientId: 'dummyClientId',
+      clientSecret: 'dummyClientSecret',
+      munchkinId: 'dummyMunchkinId',
+    };
+
+    await expect(util.getAccessToken(config)).rejects.toThrow(AbortedError);
+  });
 });