fix: addressing minor issues related to naming, used lodash.isNil ins…

…tead of identifying the valid values manually, added test-cases Signed-off-by: Sai Sankeerth <[email protected]>
rudderlabs · Nov 9, 2023 · b782b90 · b782b90
1 parent a825926
commit b782b90
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 6 deletions.
diff --git a/src/helpers/geoLocation.ts b/src/helpers/geoLocation.ts
@@ -29,17 +29,17 @@ export default class GeoLocationHelper {
       return {};
     }
     const { value: address, key: addressKey } = GeoLocationHelper.getAddressKeyAndValue(message);
-    const addressFieldMapping = {
+    const addressFieldToGeoFieldMap = {
       city: 'city',
       country: 'country',
       postalCode: 'postal',
       state: 'region',
     };
 
-    const mappedAddress = Object.entries(addressFieldMapping).reduce(
-      (agg, [identifyAddressKey, geoKey]) => {
-        if (!address?.[identifyAddressKey] && msg?.context?.geo?.[geoKey]) {
-          return { [identifyAddressKey]: msg.context.geo[geoKey], ...agg };
+    const mappedAddress = Object.entries(addressFieldToGeoFieldMap).reduce(
+      (agg, [addressFieldKey, geoFieldKey]) => {
+        if (!address?.[addressFieldKey] && msg?.context?.geo?.[geoFieldKey]) {
+          return { [addressFieldKey]: msg.context.geo[geoFieldKey], ...agg };
         }
         return agg;
       },

diff --git a/src/v0/util/index.js b/src/v0/util/index.js
@@ -676,7 +676,7 @@ const getFirstMatchingKeyAndValue = (message, sourceKeys) => {
   // eslint-disable-next-line no-restricted-syntax
   for (const sourceKey of srcKeys) {
     const val = get(message, sourceKey);
-    if (val || val === false || val === 0) {
+    if (!lodash.isNil(val)) {
       // return only if the value is valid.
       // else look for next possible source in precedence
       return { value: val, key: sourceKey };

diff --git a/test/utils/getFirstMatchingKeyAndValue.test.ts b/test/utils/getFirstMatchingKeyAndValue.test.ts
@@ -117,6 +117,44 @@ const getFirstMatchKVCases = [
       key: '1.c.d',
     },
   },
+  {
+    description: 'should get value as "0"',
+    input: {
+      message: {
+        player: 'Roger Federer',
+        sport: 'Tennis',
+        rivals: {
+          spain: 0,
+          serbia: 'Novak Djokovic',
+          switzerland: 'Stan Wawrinka',
+        },
+      },
+      sourceKeys: ['spain.rivals', 'rivals.spain'],
+    },
+    expectedOutput: {
+      value: 0,
+      key: 'rivals.spain',
+    },
+  },
+  {
+    description: 'show get value as false',
+    input: {
+      message: {
+        player: 'Roger Federer',
+        sport: 'Tennis',
+        rivals: {
+          spain: false,
+          serbia: 'Novak Djokovic',
+          switzerland: 'Stan Wawrinka',
+        },
+      },
+      sourceKeys: ['spain.rivals', 'rivals.spain'],
+    },
+    expectedOutput: {
+      value: false,
+      key: 'rivals.spain',
+    },
+  },
 ];
 
 describe('getFirstMatchingKeyAndValue tests', () => {