feat: remove redundant data from traits in hubspot

rudderlabs · Apr 17, 2024 · ab153f0 · ab153f0
1 parent 0b57204
commit ab153f0
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/src/v0/destinations/hs/HSTransform-v2.js b/src/v0/destinations/hs/HSTransform-v2.js
@@ -110,11 +110,11 @@ const processIdentify = async (message, destination, propertyMap) => {
     GENERIC_TRUE_VALUES.includes(mappedToDestination.toString()) &&
     operation
   ) {
-    addExternalIdToHSTraits(message);
     if (!objectType) {
       throw new InstrumentationError('objectType not found');
     }
     if (operation === 'createObject') {
+      addExternalIdToHSTraits(message);
       endpoint = CRM_CREATE_UPDATE_ALL_OBJECTS.replace(':objectType', objectType);
     } else if (operation === 'updateObject' && getHsSearchId(message)) {
       const { hsSearchId } = getHsSearchId(message);

diff --git a/test/integrations/destinations/hs/processor/data.ts b/test/integrations/destinations/hs/processor/data.ts
@@ -1534,7 +1534,6 @@ export const data = [
                     firstname: 'Test Hubspot',
                     anonymousId: '12345',
                     country: 'India',
-                    email: '[email protected]',
                   },
                 },
                 XML: {},

diff --git a/test/integrations/destinations/hs/router/data.ts b/test/integrations/destinations/hs/router/data.ts
@@ -1033,7 +1033,6 @@ export const data = [
                           firstname: 'Test Hubspot',
                           anonymousId: '12345',
                           country: 'India',
-                          email: '[email protected]',
                         },
                         id: '103605',
                       },