chore: changes in transformation error handling

rudderlabs · Jun 17, 2024 · a80d403 · a80d403
1 parent bb94c81
commit a80d403
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/src/util/ivmFactory.js b/src/util/ivmFactory.js
@@ -243,12 +243,15 @@ async function createIvm(code, libraryVersionIds, versionId, credentials, secret
     }),
   );
 
-  await jail.set('_credential', function (key) {
+  await jail.set('_credential', function (...args) {
     if (_.isNil(credentials) || !_.isObject(credentials)) {
-      throw new Error('Credentials in incorrect format');
+      logger.error('Error fetching credentials map');
+      stats.increment('credential_error', { versionId });
+      return undefined;
     }
-    if (key.length > 1 || _.isNil(key[0]) || !_.isString(key[0])) {
-      throw new Error('Key should be a string');
+    const key = args[0][0];
+    if (_.isNil(key)) {
+      throw new Error('Key should be valid and defined');
     }
     return credentials[key];
   });

diff --git a/src/util/prometheus.js b/src/util/prometheus.js
@@ -569,6 +569,12 @@ class Prometheus {
           'module',
         ],
       },
+      {
+        name: 'credentials_error',
+        help: 'Error in fetching credentials count',
+        type: 'counter',
+        labelNames: ['versionId'],
+      },
 
       // Gauges
       {

diff --git a/test/__tests__/user_transformation.test.js b/test/__tests__/user_transformation.test.js
@@ -1171,7 +1171,7 @@ describe("User transformation", () => {
       expect(fetch).toHaveBeenCalledWith(
         `https://api.rudderlabs.com/transformation/getByVersionId?versionId=${versionId}`
       );
-      expect(output[0].error).toMatch(/Key should be a string/);
+      expect(output[0].error).toMatch(/Key should be valid and defined/);
     });
 
     it(`Simple ${name} Test with credentials with multiple arguements for codeVersion 1`, async () => {
@@ -1185,7 +1185,7 @@ describe("User transformation", () => {
         name,
         code: `
           export function transformEvent(event, metadata) {
-              event.credentialValue = credential('arg1', 'arg2');
+              event.credentialValue = credential('key1', 'key2');
               return event;
             }
             `
@@ -1200,7 +1200,7 @@ describe("User transformation", () => {
       expect(fetch).toHaveBeenCalledWith(
         `https://api.rudderlabs.com/transformation/getByVersionId?versionId=${versionId}`
       );
-      expect(output[0].error).toMatch(/Key should be a string/);
+      expect(output[0].transformedEvent.credentialValue).toEqual("value1");
     });
 
     it(`Simple ${name} Test with credentials with non string key for codeVersion 1`, async () => {
@@ -1229,7 +1229,7 @@ describe("User transformation", () => {
       expect(fetch).toHaveBeenCalledWith(
         `https://api.rudderlabs.com/transformation/getByVersionId?versionId=${versionId}`
       );
-      expect(output[0].error).toMatch(/Key should be a string/);
+      expect(output[0].transformedEvent.credentialValue).toEqual(undefined);
     });
 
     it(`Simple ${name} Test with credentials without value for codeVersion 1`, async () => {