fix: only new users to have default signUp date

rudderlabs · Dec 26, 2023 · 9da315c · 9da315c
1 parent 429ca71
commit 9da315c
Show file tree

Hide file tree

Showing 5 changed files with 2,725 additions and 2,410 deletions.
diff --git a/src/v0/destinations/gainsight_px/data/GainsightPX_Identify.json b/src/v0/destinations/gainsight_px/data/GainsightPX_Identify.json
@@ -55,12 +55,7 @@
   },
   {
     "destKey": "signUpDate",
-    "sourceKeys": [
-      "traits.signUpDate",
-      "context.traits.signUpDate",
-      "timestamp",
-      "originalTimestamp"
-    ],
+    "sourceKeys": ["traits.signUpDate", "context.traits.signUpDate"],
     "required": false,
     "metadata": {
       "type": "timestamp"

diff --git a/src/v0/destinations/gainsight_px/transform.js b/src/v0/destinations/gainsight_px/transform.js
@@ -1,5 +1,9 @@
 /* eslint-disable no-nested-ternary */
-const { InstrumentationError, ConfigurationError } = require('@rudderstack/integrations-lib');
+const {
+  InstrumentationError,
+  ConfigurationError,
+  formatTimeStamp,
+} = require('@rudderstack/integrations-lib');
 const { EventType } = require('../../../constants');
 const {
   isEmptyObject,
@@ -56,6 +60,10 @@ const identifyResponseBuilder = async (message, { Config }) => {
     payload.firstName = fName;
     payload.lastName = lName;
   }
+  // Only for the case of new user creation, if signUpDate is not provided in traits, timestamp / originalTimestamp is mapped
+  if (!isPresent && !payload.signUpDate) {
+    payload.signUpDate = formatTimeStamp(message.timestamp || message.originalTimestamp);
+  }
   let customAttributes = {};
   customAttributes = extractCustomFields(
     message,

diff --git a/src/v0/destinations/salesforce/transform.js b/src/v0/destinations/salesforce/transform.js
@@ -221,6 +221,7 @@ async function getSalesforceIdFromPayload(
     if (!email) {
       throw new InstrumentationError('Invalid Email address for Lead Objet');
     }
+    // we need to make this url dynamic this is defaulting to lead.
     const leadQueryUrl = `${authorizationData.instanceUrl}/services/data/v${SF_API_VERSION}/parameterizedSearch/?q=${email}&sobject=Lead&Lead.fields=id,IsConverted,ConvertedContactId,IsDeleted`;
 
     // request configuration will be conditional