fix: comments addressed

rudderlabs · Apr 9, 2024 · 986507c · 986507c
1 parent 142675f
commit 986507c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/v0/destinations/sfmc/transform.js b/src/v0/destinations/sfmc/transform.js
@@ -59,7 +59,7 @@ const getToken = async (clientId, clientSecret, subdomain) => {
       {
         [tags.TAG_NAMES.ERROR_TYPE]: getDynamicErrorType(processedResponseSfmc.status || 400),
       },
-      JSON.stringify(processedResponseSfmc),
+      processedResponseSfmc.response,
     );
   }
 

diff --git a/test/integrations/destinations/sfmc/processor/data.ts b/test/integrations/destinations/sfmc/processor/data.ts
@@ -1987,7 +1987,7 @@ export const data = [
         body: [
           {
             error:
-              '{"message":"Could not retrieve access token","destinationResponse":"{\\"response\\":{\\"error\\":\\"invalid_client\\",\\"error_description\\":\\"Invalid client ID. Use the client ID in Marketing Cloud Installed Packages.\\",\\"error_uri\\":\\"https://developer.salesforce.com/docs\\"},\\"status\\":401}"}',
+              '{"message":"Could not retrieve access token","destinationResponse":{"error":"invalid_client","error_description":"Invalid client ID. Use the client ID in Marketing Cloud Installed Packages.","error_uri":"https://developer.salesforce.com/docs"}}',
             statTags: {
               destType: 'SFMC',
               errorCategory: 'network',
@@ -2059,7 +2059,7 @@ export const data = [
         body: [
           {
             error:
-              '{"message":"Could not retrieve access token","destinationResponse":"{\\"response\\":{\\"message\\":\\"Your requests are temporarily blocked.\\",\\"errorcode\\":50200,\\"documentation\\":\\"https://developer.salesforce.com/docs/atlas.en-us.mc-apis.meta/mc-apis/error-handling.htm\\"},\\"status\\":429}"}',
+              '{"message":"Could not retrieve access token","destinationResponse":{"message":"Your requests are temporarily blocked.","errorcode":50200,"documentation":"https://developer.salesforce.com/docs/atlas.en-us.mc-apis.meta/mc-apis/error-handling.htm"}}',
             statTags: {
               destType: 'SFMC',
               errorCategory: 'network',
@@ -2130,8 +2130,7 @@ export const data = [
         status: 200,
         body: [
           {
-            error:
-              '{"message":"Could not retrieve access token","destinationResponse":"{\\"response\\":{},\\"status\\":400}"}',
+            error: '{"message":"Could not retrieve access token","destinationResponse":{}}',
             statTags: {
               destType: 'SFMC',
               errorCategory: 'network',
@@ -2202,8 +2201,7 @@ export const data = [
         status: 200,
         body: [
           {
-            error:
-              '{"message":"Could not retrieve access token","destinationResponse":"{\\"response\\":\\"\\",\\"status\\":500}"}',
+            error: 'Could not retrieve access token',
             statTags: {
               destType: 'SFMC',
               errorCategory: 'network',
-Original file line number
+Diff line change
@@ Expand Up @@
           {
             [tags.TAG_NAMES.ERROR_TYPE]: getDynamicErrorType(processedResponseSfmc.status || 400),
           },
-          JSON.stringify(processedResponseSfmc),
+          processedResponseSfmc.response,
         );
       }
@@ Expand Down @@