Merge branch 'develop' into feat.amp-screen

rudderlabs · Nov 13, 2023 · 8ffd61c · 8ffd61c
2 parents 8d0219f + e82cef8
commit 8ffd61c
Show file tree

Hide file tree

Showing 7 changed files with 254 additions and 36 deletions.
diff --git a/src/v0/destinations/facebook_conversions/config.js b/src/v0/destinations/facebook_conversions/config.js
@@ -1,7 +1,7 @@
 const { getMappingConfig } = require('../../util');
 
 const ENDPOINT = (datasetId, accessToken) =>
-  `https://graph.facebook.com/v17.0/${datasetId}/events?access_token=${accessToken}`;
+  `https://graph.facebook.com/v18.0/${datasetId}/events?access_token=${accessToken}`;
 
 const CONFIG_CATEGORIES = {
   USERDATA: {

diff --git a/src/v0/destinations/facebook_conversions/transform.js b/src/v0/destinations/facebook_conversions/transform.js
@@ -14,7 +14,6 @@ const { EventType } = require('../../../constants');
 const {
   constructPayload,
   extractCustomFields,
-  flattenJson,
   getIntegrationsObj,
   getValidDynamicFormConfig,
   simpleProcessRouterDest,
@@ -73,8 +72,11 @@ const responseBuilderSimple = (message, category, destination) => {
   commonData.action_source = getActionSource(commonData, actionSource);
 
   let customData = {};
-  customData = flattenJson(
-    extractCustomFields(message, customData, ['properties'], FB_CONVERSIONS_DEFAULT_EXCLUSION),
+  customData = extractCustomFields(
+    message,
+    customData,
+    ['properties'],
+    FB_CONVERSIONS_DEFAULT_EXCLUSION,
   );
 
   customData = transformedPayloadData(

diff --git a/src/v0/destinations/facebook_conversions/utils.js b/src/v0/destinations/facebook_conversions/utils.js
@@ -44,7 +44,11 @@ const getCategoryFromEvent = (eventName) => {
   return category;
 };
 
-const populateContentsAndContentIDs = (productPropertiesArray, fallbackQuantity) => {
+const populateContentsAndContentIDs = (
+  productPropertiesArray,
+  fallbackQuantity,
+  fallbackDeliveryCategory,
+) => {
   const contentIds = [];
   const contents = [];
   if (Array.isArray(productPropertiesArray)) {
@@ -57,6 +61,7 @@ const populateContentsAndContentIDs = (productPropertiesArray, fallbackQuantity)
             id: productId,
             quantity: productProps.quantity || fallbackQuantity || 1,
             item_price: productProps.price,
+            delivery_category: productProps.delivery_category || fallbackDeliveryCategory,
           });
         }
       }
@@ -142,6 +147,7 @@ const populateCustomDataBasedOnCategory = (customData, message, category, catego
       const { contentIds, contents } = populateContentsAndContentIDs(
         message.properties?.products,
         message.properties?.quantity,
+        message.properties?.delivery_category,
       );
 
       const contentCategory = eventTypeCustomData.content_category;