fix: small edit and adding test cases

rudderlabs · Dec 18, 2023 · 8bbae29 · 8bbae29
1 parent 0c91d9c
commit 8bbae29
Show file tree

Hide file tree

Showing 4 changed files with 3,564 additions and 166 deletions.
diff --git a/src/cdk/v2/destinations/pinterest_tag/procWorkflow.yaml b/src/cdk/v2/destinations/pinterest_tag/procWorkflow.yaml
@@ -9,6 +9,8 @@ bindings:
     path: ../../../../v0/util
   - name: removeUndefinedAndNullAndEmptyValues
     path: ../../../../v0/util
+  - name: validateEventName
+    path: ../../../../v0/util
 steps:
   - name: checkIfProcessed
     condition: .message.statusCode
@@ -175,13 +177,13 @@ steps:
       name: eventNamesForOthers
       template: |
         let event = .message.event ?? .message.name;
-        let stringifiedEvent = event.toString();
-        let eventInLowerCase = stringifiedEvent.toLowerCase();
+        $.validateEventName(event);
+        let eventInLowerCase = event.toLowerCase();
         let eventNames = .destination.Config.eventsMapping.(){.from === event}.to[] ?? [];
         eventNames = $.convertToSnakeCase(eventNames);
         eventNames.length === 0 ? eventNames = $.ecomEventMaps.(){eventInLowerCase in .src}.dest[] ?? [];
         (eventNames.length === 0 && .destination.Config.sendAsCustomEvent) ? eventNames = ["custom"];
-        eventNames.length === 0 ? eventNames = [event.toString()];
+        eventNames.length === 0 ? eventNames = [event];
         eventNames;
 
   - name: payload
@@ -227,7 +229,6 @@ steps:
       name: buildResponseForProcessTransformationV5
       description: build response using V5 API
       template: |
-       console.log(JSON.stringify($.outputs.payload))
         $.outputs.payload.().({
           "body": {
             "JSON": .,
@@ -245,4 +246,4 @@ steps:
           },
           "params": $.outputs.checkSendTestEventConfig,
           "files": {}
-        })[]
+        })[]
diff --git a/src/v0/destinations/pinterest_tag/utils.js b/src/v0/destinations/pinterest_tag/utils.js
@@ -8,6 +8,7 @@ const {
   isDefined,
   getHashFromArrayWithDuplicate,
   removeUndefinedAndNullValues,
+  validateEventName,
 } = require('../../util');
 const { COMMON_CONFIGS, CUSTOM_CONFIGS, API_VERSION } = require('./config');
 
@@ -166,10 +167,11 @@ const deduceTrackScreenEventName = (message, Config) => {
   let eventName;
   const { event, name } = message;
   const { eventsMapping, sendAsCustomEvent } = Config;
-  const trackEventOrScreenName = event.toString() || name.toString();
+  const trackEventOrScreenName = event || name;
   if (!trackEventOrScreenName) {
     throw new InstrumentationError('event_name could not be mapped. Aborting');
   }
+  validateEventName(trackEventOrScreenName);
 
   /*
   Step 1: If the event is not amongst the above list of ecommerce events, will look for