chore: add request size metric

rudderlabs · Mar 15, 2024 · 8bb568d · 8bb568d
1 parent 21c8b48
commit 8bb568d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/src/controllers/userTransform.ts b/src/controllers/userTransform.ts
@@ -15,9 +15,10 @@ export class UserTransformController {
       '(User transform - router:/customTransform ):: Request to transformer',
       JSON.stringify(ctx.request.body),
     );
+    const requestSize = Number(ctx.request.get('content-length'));
     const events = ctx.request.body as ProcessorTransformationRequest[];
     const processedRespone: UserTransformationServiceResponse =
-      await UserTransformService.transformRoutine(events, ctx.state.features);
+      await UserTransformService.transformRoutine(events, ctx.state.features, requestSize);
     ctx.body = processedRespone.transformedEvents;
     ControllerUtility.postProcess(ctx, processedRespone.retryStatus);
     logger.debug(

diff --git a/src/services/userTransform.ts b/src/services/userTransform.ts
@@ -28,6 +28,7 @@ export class UserTransformService {
   public static async transformRoutine(
     events: ProcessorTransformationRequest[],
     features: FeatureFlags = {},
+    requestSize = 0,
   ): Promise<UserTransformationServiceResponse> {
     let retryStatus = 200;
     const groupedEvents: NonNullable<unknown> = groupBy(
@@ -162,24 +163,20 @@ export class UserTransformService {
             ),
           );
           stats.counter('user_transform_errors', eventsToProcess.length, {
-            ...getTransformationMetadata(eventsToProcess[0]?.metadata),
             status,
             ...metaTags,
+            ...getTransformationMetadata(eventsToProcess[0]?.metadata),
           });
         } finally {
           stats.timing('user_transform_request_latency', userFuncStartTime, {
-            ...getTransformationMetadata(eventsToProcess[0]?.metadata),
             ...metaTags,
+            ...getTransformationMetadata(eventsToProcess[0]?.metadata),
           });
 
-          stats.histogram(
-            'user_transform_request_size',
-            Buffer.byteLength(JSON.stringify(eventsToProcess)),
-            {
-              ...getTransformationMetadata(eventsToProcess[0]?.metadata),
-              ...metaTags,
-            },
-          );
+          stats.histogram('user_transform_batch_size', requestSize, {
+            ...metaTags,
+            ...getTransformationMetadata(eventsToProcess[0]?.metadata),
+          });
         }
 
         stats.counter('user_transform_requests', 1, {});

diff --git a/src/util/prometheus.js b/src/util/prometheus.js
@@ -675,8 +675,8 @@ class Prometheus {
         ],
       },
       {
-        name: 'user_transform_request_size',
-        help: 'user_transform_request_size',
+        name: 'user_transform_batch_size',
+        help: 'user_transform_batch_size',
         type: 'histogram',
         labelNames: [
           'workspaceId',