Merge branch 'develop' into feat.onboard.record.event.support.msl

rudderlabs · Nov 7, 2023 · 89ab93f · 89ab93f
2 parents f46149d + 11fb7c4
commit 89ab93f
Show file tree

Hide file tree

Showing 723 changed files with 299,870 additions and 251,296 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -28,7 +28,7 @@
     ],
     "unicorn/no-instanceof-array": "error",
     "unicorn/no-static-only-class": "error",
-    "unicorn/consistent-destructuring": "off",
+    "unicorn/consistent-destructuring": "error",
     "unicorn/better-regex": "error",
     "unicorn/no-for-loop": "error",
     "unicorn/prefer-array-some": "error",
@@ -40,29 +40,31 @@
     "unicorn/no-useless-spread": "error",
     "unicorn/no-useless-length-check": "error",
     "unicorn/prefer-export-from": "error",
-    "import/no-dynamic-require": "warn",
-    "no-param-reassign": "warn",
+    "import/no-dynamic-require": "error",
+    "no-param-reassign": "error",
     "sonarjs/prefer-immediate-return": "off",
     "sonarjs/no-nested-template-literals": "off",
-    "sonarjs/max-switch-cases": "off",
-    "sonarjs/no-small-switch": "warn",
+    "sonarjs/max-switch-cases": "error",
+    "sonarjs/no-small-switch": "error",
     "sonarjs/cognitive-complexity": ["error", 60],
     "@typescript-eslint/no-var-requires": "off",
-    "global-require": "off",
-    "@typescript-eslint/naming-convention": "off",
-    "@typescript-eslint/ban-types": "off",
+    "global-require": "error",
+    "@typescript-eslint/naming-convention": "error",
+    "@typescript-eslint/ban-types": "error",
+    "@typescript-eslint/no-explicit-any": "off",
     "class-methods-use-this": "off",
-    "@typescript-eslint/return-await": "off",
-    "import/prefer-default-export": "off",
-    "sonarjs/no-ignored-return": "off",
-    "no-new": "off",
-    "@typescript-eslint/no-shadow": "off",
-    "@typescript-eslint/no-loop-func": "off",
-    "sonarjs/no-same-line-conditional": "off",
-    "no-restricted-syntax": "off",
-    "sonarjs/no-duplicate-string": "off",
-    "sonarjs/no-identical-functions": "off",
+    "@typescript-eslint/return-await": "error",
+    "import/prefer-default-export": "error",
+    "sonarjs/no-ignored-return": "error",
+    "no-new": "error",
+    "@typescript-eslint/no-shadow": "error",
+    "@typescript-eslint/no-loop-func": "error",
+    "sonarjs/no-same-line-conditional": "error",
+    "no-restricted-syntax": "error",
+    "sonarjs/no-duplicate-string": "error",
+    "sonarjs/no-identical-functions": "error",
     "no-prototype-builtins": "off",
-    "@typescript-eslint/dot-notation": "off"
+    "@typescript-eslint/dot-notation": "error",
+    "@typescript-eslint/no-unused-vars": "error"
   }
 }
diff --git a/.github/workflows/build-push-docker-image.yml b/.github/workflows/build-push-docker-image.yml
@@ -21,6 +21,8 @@ on:
       push_target:
         required: true
         type: string
+      build_type:
+        type: string
     secrets:
       DOCKERHUB_PROD_TOKEN:
         required: true
@@ -147,3 +149,15 @@ jobs:
       - name: Create multi-arch manifest
         run: |
           docker buildx imagetools create -t ${{ inputs.push_tags }} ${{ inputs.push_tags }}-amd64 ${{ inputs.push_tags }}-arm64
+
+      - name: Create latest multi-arch manifest
+        # To be triggered only for release/hotfix PR merges coming from `prepare-for-prod-deploy.yaml`
+        if: ${{ inputs.build_type == 'dt' }}
+        run: |
+          docker buildx imagetools create -t rudderstack/rudder-transformer:latest ${{ inputs.push_tags }}-amd64 ${{ inputs.push_tags }}-arm64
+      
+      - name: Create latest ut multi-arch manifest
+        # To be triggered only for release/hotfix PR merges coming from `prepare-for-prod-ut-deploy.yaml`
+        if: ${{ inputs.build_type == 'ut' }}
+        run: |
+          docker buildx imagetools create -t rudderstack/rudder-transformer:ut-latest ${{ inputs.push_tags }}-amd64 ${{ inputs.push_tags }}-arm64
diff --git a/.github/workflows/create-hotfix-branch.yml b/.github/workflows/create-hotfix-branch.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
 
     # Only allow these users to create new hotfix branch from 'main'
-    if: github.ref == 'refs/heads/main' && (github.actor == 'ItsSudip' || github.actor == 'krishna2020' || github.actor == 'saikumarrs' || github.actor == 'sandeepdsvs' || github.actor == 'shrouti1507') && (github.triggering_actor == 'ItsSudip' || github.triggering_actor == 'krishna2020' ||  github.triggering_actor == 'saikumarrs' || github.triggering_actor == 'sandeepdsvs' || github.triggering_actor == 'shrouti1507')
+    if: github.ref == 'refs/heads/main' && (github.actor == 'ItsSudip' || github.actor == 'krishna2020' || github.actor == 'saikumarrs' || github.actor == 'sandeepdsvs' || github.actor == 'shrouti1507' || github.actor == 'anantjain45823' || github.actor == 'chandumlg' || github.actor == 'mihir-4116' || github.actor == 'ujjwal-ab') && (github.triggering_actor == 'ItsSudip' || github.triggering_actor == 'krishna2020' ||  github.triggering_actor == 'saikumarrs' || github.triggering_actor == 'sandeepdsvs' || github.triggering_actor == 'shrouti1507' || github.triggering_actor == 'anantjain45823' || github.triggering_actor == 'chandumlg' || github.triggering_actor == 'mihir-4116' || github.triggering_actor == 'ujjwal-ab)
     steps:
       - name: Create Branch
         uses: peterjgrainger/[email protected]

diff --git a/.github/workflows/draft-new-release.yml b/.github/workflows/draft-new-release.yml
@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
 
     # Only allow release stakeholders to initiate releases
-    if: (github.ref == 'refs/heads/develop' || startsWith(github.ref, 'refs/heads/hotfix/')) && (github.actor == 'ItsSudip' || github.actor == 'krishna2020' || github.actor == 'saikumarrs' || github.actor == 'sandeepdsvs' || github.actor == 'shrouti1507') &&  (github.triggering_actor == 'ItsSudip' || github.triggering_actor == 'krishna2020' || github.triggering_actor == 'saikumarrs' || github.triggering_actor == 'sandeepdsvs' || github.triggering_actor == 'shrouti1507')
+    if: (github.ref == 'refs/heads/develop' || startsWith(github.ref, 'refs/heads/hotfix/')) && (github.actor == 'ItsSudip' || github.actor == 'krishna2020' || github.actor == 'saikumarrs' || github.actor == 'sandeepdsvs' || github.actor == 'shrouti1507' || github.actor == 'anantjain45823'  || github.actor == 'chandumlg' || github.actor == 'mihir-4116' || github.actor == 'yashasvibajpai' || github.actor == 'sanpj2292' || github.actor == 'ujjwal-ab') &&  (github.triggering_actor == 'ItsSudip' || github.triggering_actor == 'krishna2020' || github.triggering_actor == 'saikumarrs' || github.triggering_actor == 'sandeepdsvs' || github.triggering_actor == 'shrouti1507' || github.triggering_actor == 'anantjain45823' || github.triggering_actor == 'chandumlg' || github.triggering_actor == 'mihir-4116' || github.triggering_actor == 'yashasvibajpai' || github.triggering_actor == 'sanpj2292' || github.triggering_actor == 'ujjwal-ab')
     steps:
       - name: Checkout
         uses: actions/[email protected]

diff --git a/.github/workflows/prepare-for-prod-deploy.yml b/.github/workflows/prepare-for-prod-deploy.yml
@@ -47,11 +47,12 @@ jobs:
     uses: ./.github/workflows/build-push-docker-image.yml
     with:
       build_tag: rudderstack/rudder-transformer:${{ needs.generate-tag-names.outputs.tag_name }}
-      push_tags: rudderstack/rudder-transformer:${{ needs.generate-tag-names.outputs.tag_name }},rudderstack/rudder-transformer:latest
+      push_tags: rudderstack/rudder-transformer:${{ needs.generate-tag-names.outputs.tag_name }}
       img_tag: ${{ needs.generate-tag-names.outputs.tag_name }}
       dockerfile: Dockerfile
       load_target: development
       push_target: production
+      build_type: dt
     secrets:
       DOCKERHUB_PROD_TOKEN: ${{ secrets.DOCKERHUB_PROD_TOKEN }}
 
@@ -125,7 +126,7 @@ jobs:
           git commit -m "chore: upgrade shared transformers to $TAG_NAME"
           git push -u origin shared-transformer-$TAG_NAME
 
-          hub pull-request -m "chore: upgrade shared transformers to $TAG_NAME"
+          gh pr create --fill
 
       - name: Update Helm Chart and Raise Pull Request For Hosted Transformer
         env:
@@ -142,4 +143,4 @@ jobs:
           git commit -m "chore: upgrade hosted transformer to $TAG_NAME"
           git push -u origin hosted-transformer-$TAG_NAME
 
-          hub pull-request -m "chore: upgrade hosted transformer to $TAG_NAME"  
+          gh pr create --fill
diff --git a/.github/workflows/prepare-for-prod-rollback.yml b/.github/workflows/prepare-for-prod-rollback.yml
@@ -10,7 +10,7 @@ jobs:
 
     # Only allow to be deployed from tags and main branch
     # Only allow specific actors to trigger
-    if: (startsWith(github.ref, 'refs/tags/') || startsWith(github.ref, 'refs/heads/main')) && (github.actor == 'ItsSudip' || github.actor == 'krishna2020' || github.actor == 'saikumarrs') && (github.triggering_actor == 'ItsSudip' || github.triggering_actor == 'krishna2020' || github.triggering_actor == 'saikumarrs')
+    if: (startsWith(github.ref, 'refs/tags/') || startsWith(github.ref, 'refs/heads/main')) && (github.actor == 'ItsSudip' || github.actor == 'krishna2020' || github.actor == 'saikumarrs'  || github.actor == 'chandumlg') && (github.triggering_actor == 'ItsSudip' || github.triggering_actor == 'krishna2020' || github.triggering_actor == 'saikumarrs' || github.triggering_actor == 'chandumlg')
 
     steps:
       - name: Get Target Version
@@ -56,4 +56,4 @@ jobs:
           git commit -m "chore: rollback shared transformers to ${{ steps.target-version.outputs.tag_name }}"
           git push -u origin shared-transformer-rollback-${{ steps.target-version.outputs.tag_name }}
 
-          hub pull-request -m "chore: rollback shared transformers to ${{ steps.target-version.outputs.tag_name }}"
+          gh pr create --fill
diff --git a/.github/workflows/prepare-for-prod-ut-deploy.yml b/.github/workflows/prepare-for-prod-ut-deploy.yml
@@ -50,11 +50,12 @@ jobs:
     uses: ./.github/workflows/build-push-docker-image.yml
     with:
       build_tag: rudderstack/rudder-transformer:${{ needs.generate-tag-names.outputs.tag_name_ut }}
-      push_tags: rudderstack/rudder-transformer:${{ needs.generate-tag-names.outputs.tag_name_ut }},rudderstack/rudder-transformer:ut-latest
+      push_tags: rudderstack/rudder-transformer:${{ needs.generate-tag-names.outputs.tag_name_ut }}
       img_tag: ${{ needs.generate-tag-names.outputs.tag_name_ut }}
       dockerfile: Dockerfile-ut-func
       load_target: development
       push_target: production
+      build_type: ut
     secrets:
       DOCKERHUB_PROD_TOKEN: ${{ secrets.DOCKERHUB_PROD_TOKEN }}
 
@@ -110,7 +111,7 @@ jobs:
           git commit -m "chore: upgrade shared user-transformers to $UT_TAG_NAME"
           git push -u origin shared-user-transformer-$UT_TAG_NAME
 
-          hub pull-request -m "chore: upgrade shared user-transformers to $UT_TAG_NAME"
+          gh pr create --fill
 
       - name: Update Helm Chart and Raise Pull Request For Hosted Transformer
         env:
@@ -127,4 +128,4 @@ jobs:
           git commit -m "chore: upgrade hosted user-transformer to $UT_TAG_NAME"
           git push -u origin hosted-user-transformer-$UT_TAG_NAME
 
-          hub pull-request -m "chore: upgrade hosted user-transformer to $UT_TAG_NAME"
+          gh pr create --fill
diff --git a/.github/workflows/prepare-for-staging-deploy.yml b/.github/workflows/prepare-for-staging-deploy.yml
@@ -120,5 +120,5 @@ jobs:
 
             git commit -m "chore: upgrade staging env transformers to \"$TAG_NAME\""
             git push -u origin $BRANCH_NAME
-            hub pull-request -m "chore: upgrade staging env transformers to \"$TAG_NAME\""
+            gh pr create --fill
           fi