chore: address commentsx2

rudderlabs · Apr 18, 2024 · 8541223 · 8541223
1 parent b61cbc1
commit 8541223
Show file tree

Hide file tree

Showing 2 changed files with 174 additions and 3 deletions.
diff --git a/src/cdk/v2/destinations/yandex_metrica_offline_events/utils.js b/src/cdk/v2/destinations/yandex_metrica_offline_events/utils.js
@@ -1,4 +1,4 @@
-const { InstrumentationError } = require('@rudderstack/integrations-lib');
+const { InstrumentationError, isDefinedNotNullNotEmpty } = require('@rudderstack/integrations-lib');
 
 const setIdentifier = (data, identifierType, identifierValue) => {
   const updatedData = data;
@@ -18,7 +18,7 @@ const setIdentifier = (data, identifierType, identifierValue) => {
 
 const validateData = (data) => {
   const { Price } = data;
-  if (!data) {
+  if (!isDefinedNotNullNotEmpty(data)) {
     throw new InstrumentationError('No traits found in the payload. Aborting!');
   }
   if (Price && typeof Price !== 'number') {

diff --git a/test/integrations/destinations/yandex_metrica_offline_events/processor/data.ts b/test/integrations/destinations/yandex_metrica_offline_events/processor/data.ts
@@ -295,7 +295,7 @@ export const data = [
   },
   {
     name: 'yandex_metrica_offline_events',
-    description: 'Successful identify event with UserId identifier type',
+    description: 'Failed identify event with Price passed as string',
     feature: 'processor',
     module: 'destination',
     version: 'v0',
@@ -381,4 +381,175 @@ export const data = [
       },
     },
   },
+  {
+    name: 'yandex_metrica_offline_events',
+    description: 'Failed identify event with traits missing',
+    feature: 'processor',
+    module: 'destination',
+    version: 'v0',
+    input: {
+      request: {
+        body: [
+          {
+            message: {
+              type: 'identify',
+              traits: {},
+              userId: '',
+              channel: 'sources',
+              context: {
+                sources: {
+                  job_id: '2du7rQyxlbIJl4LKgZAaaErEjcE',
+                  version: '1849/merge',
+                  job_run_id: 'cnsn3tt5fleigsfclr6g',
+                  task_run_id: 'cnsn3tt5fleigsfclr70',
+                },
+                externalId: [
+                  {
+                    id: '133591247640966458',
+                    type: 'YANDEX_METRICA_OFFLINE_EVENTS-conversions',
+                    identifierType: 'UserId',
+                  },
+                ],
+                mappedToDestination: 'true',
+              },
+              recordId: '1',
+              rudderId: '14a58046-23a5-46bd-afbf-87c8acaa9d2e',
+              messageId: '91ef85d9-b170-440c-bae2-6284d4070338',
+            },
+            destination: {
+              DestinationDefinition: {
+                Config: {
+                  cdkV2Enabled: true,
+                },
+              },
+              Config: {
+                counterId: '574342423',
+                goalId: '23432565',
+                rudderAccountId: '2du7fLeK82nk9L2Xd1X507uiD1B',
+                authStatus: 'active',
+              },
+            },
+            metadata: {
+              destinationId: 'destId',
+              workspaceId: 'wspId',
+            },
+          },
+        ],
+      },
+    },
+    output: {
+      response: {
+        status: 200,
+        body: [
+          {
+            statusCode: 400,
+            error:
+              'No traits found in the payload. Aborting!: Workflow: procWorkflow, Step: prepareData, ChildStep: undefined, OriginalError: No traits found in the payload. Aborting!',
+            statTags: {
+              destType: 'YANDEX_METRICA_OFFLINE_EVENTS',
+              destinationId: 'destId',
+              errorCategory: 'dataValidation',
+              errorType: 'instrumentation',
+              feature: 'processor',
+              implementation: 'cdkV2',
+              module: 'destination',
+              workspaceId: 'wspId',
+            },
+            metadata: {
+              destinationId: 'destId',
+              workspaceId: 'wspId',
+            },
+          },
+        ],
+      },
+    },
+  },
+  {
+    name: 'yandex_metrica_offline_events',
+    description: 'Failed identify event with invalid identifier type',
+    feature: 'processor',
+    module: 'destination',
+    version: 'v0',
+    input: {
+      request: {
+        body: [
+          {
+            message: {
+              type: 'identify',
+              traits: {
+                Price: 100,
+                Target: 'GOAL1',
+                Currency: 'RUB',
+                DateTime: '1481718166',
+              },
+              userId: '',
+              channel: 'sources',
+              context: {
+                sources: {
+                  job_id: '2du7rQyxlbIJl4LKgZAaaErEjcE',
+                  version: '1849/merge',
+                  job_run_id: 'cnsn3tt5fleigsfclr6g',
+                  task_run_id: 'cnsn3tt5fleigsfclr70',
+                },
+                externalId: [
+                  {
+                    id: '133591247640966458',
+                    type: 'YANDEX_METRICA_OFFLINE_EVENTS-conversions',
+                    identifierType: 'InvalidIdentifierType',
+                  },
+                ],
+                mappedToDestination: 'true',
+              },
+              recordId: '1',
+              rudderId: '14a58046-23a5-46bd-afbf-87c8acaa9d2e',
+              messageId: '91ef85d9-b170-440c-bae2-6284d4070338',
+            },
+            destination: {
+              DestinationDefinition: {
+                Config: {
+                  cdkV2Enabled: true,
+                },
+              },
+              Config: {
+                counterId: '574342423',
+                goalId: '23432565',
+                rudderAccountId: '2du7fLeK82nk9L2Xd1X507uiD1B',
+                authStatus: 'active',
+              },
+            },
+            metadata: {
+              destinationId: 'destId',
+              workspaceId: 'wspId',
+            },
+          },
+        ],
+      },
+    },
+    output: {
+      response: {
+        status: 200,
+        body: [
+          {
+            statusCode: 400,
+            error:
+              'Invalid identifier type passed in external Id. Valid types are ClientId, YCLID, UserId. Aborting!: Workflow: procWorkflow, Step: prepareData, ChildStep: undefined, OriginalError: Invalid identifier type passed in external Id. Valid types are ClientId, YCLID, UserId. Aborting!',
+            statTags: {
+              destType: 'YANDEX_METRICA_OFFLINE_EVENTS',
+              destinationId: 'destId',
+              errorCategory: 'dataValidation',
+              errorType: 'instrumentation',
+              feature: 'processor',
+              implementation: 'cdkV2',
+              module: 'destination',
+              workspaceId: 'wspId',
+            },
+            metadata: {
+              destinationId: 'destId',
+              workspaceId: 'wspId',
+            },
+          },
+        ],
+      },
+    },
+  },
 ];