feat: review comments addressed

rudderlabs · Apr 26, 2024 · 844d548 · 844d548
1 parent 561b93e
commit 844d548
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/cdk/v2/destinations/algolia/procWorkflow.yaml b/src/cdk/v2/destinations/algolia/procWorkflow.yaml
@@ -27,10 +27,7 @@ steps:
       let eventTypeMap = $.eventTypeMapping(.destination.Config);
       let event = .message.event.trim().toLowerCase();
       let eventType = .message.properties.eventType ?? eventTypeMap[event];
-      let eventSubType = .message.properties.eventSubtype && eventType === 'conversion' ? 
-                .message.properties.eventSubtype in $.ALLOWED_EVENT_SUBTYPES ? 
-                  .message.properties.eventSubtype : null
-                : null;
+      let eventSubType = .message.properties.eventSubtype && eventType === 'conversion' && (.message.properties.eventSubtype in $.ALLOWED_EVENT_SUBTYPES) ? .message.properties.eventSubtype;
       $.assert(eventType, "eventType is mandatory for track call");
       let payload = .message.().({
         index: .properties.index,
@@ -39,7 +36,7 @@ steps:
         filters: .properties.filters,
         objectIDs: .properties.objectIds,
         positions: .properties.positions,
-        value: $.isDefinedAndNotNull(.properties.currency) ? .properties.value : null,
+        value: $.isDefinedAndNotNull(.properties.currency) ? .properties.value,
         currency: .properties.currency,
         userToken: {{{{$.getGenericPaths("userId", "||")}}}},
         eventName: event,