chore: should filter out falsey reserved attributes from Intercom des…

…tination (#3767)

* Should filter out reserved attributes from Intercom destination even if they are falsey

* Fix presence check to allow null values

---------

Co-authored-by: Manish Kumar <[email protected]>

src/cdk/v2/destinations/intercom/utils.js

@@ -257,7 +257,7 @@ const filterCustomAttributes = (payload, type, destination, message) => {
   let customAttributes = { ...get(payload, 'custom_attributes') };
   if (customAttributes) {
     ReservedAttributesList.forEach((trait) => {
-      if (customAttributes[trait]) delete customAttributes[trait];
+      if (trait in customAttributes) delete customAttributes[trait];
     });
     if (isDefinedAndNotNull(customAttributes) && Object.keys(customAttributes).length > 0) {
       customAttributes =

src/cdk/v2/destinations/intercom/utils.test.js

@@ -318,6 +318,18 @@ describe('filterCustomAttributes utility test', () => {
     expect(result).toBeUndefined();
   });
 
+  it('Should filter out custom attributes that are reserved attributes and that are false', () => {
+    const payload = { custom_attributes: { unsubscribedFromEmails: false } };
+    const result = filterCustomAttributes(payload, 'user', { Config: { apiVersion: 'v2' } });
+    expect(result).toBeUndefined();
+  });
+
+  it('Should filter out custom attributes that are reserved attributes and that are null', () => {
+    const payload = { custom_attributes: { unsubscribedFromEmails: null } };
+    const result = filterCustomAttributes(payload, 'user', { Config: { apiVersion: 'v2' } });
+    expect(result).toBeUndefined();
+  });
+
   it('Should return a flattened object when custom attributes are not null, not reserved attributes and nested', () => {
     const payload = {
       custom_attributes: { source: 'rudder-js-sdk', data: { nestedAttribute: 'nestedValue' } },