chore: add types for source trasform event

rudderlabs · Sep 2, 2024 · 80afb86 · 80afb86
1 parent 55401a5
commit 80afb86
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/src/services/source/nativeIntegration.ts b/src/services/source/nativeIntegration.ts
@@ -4,6 +4,7 @@ import {
   ErrorDetailer,
   MetaTransferObject,
   RudderMessage,
+  SourceTransformationEvent,
   SourceTransformationResponse,
 } from '../../types/index';
 import stats from '../../util/stats';
@@ -27,7 +28,7 @@ export class NativeIntegrationSourceService implements SourceService {
   }
 
   public async sourceTransformRoutine(
-    sourceEvents: NonNullable<unknown>[],
+    sourceEvents: NonNullable<SourceTransformationEvent>[],
     sourceType: string,
     version: string,
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
@@ -38,7 +39,7 @@ export class NativeIntegrationSourceService implements SourceService {
     const respList: SourceTransformationResponse[] = await Promise.all<FixMe>(
       sourceEvents.map(async (sourceEvent) => {
         try {
-          const newSourceEvent = sourceEvent as { headers: any };
+          const newSourceEvent = sourceEvent;
           const { headers } = newSourceEvent;
           delete newSourceEvent.headers;
           const respEvents: RudderMessage | RudderMessage[] | SourceTransformationResponse =

diff --git a/src/types/index.ts b/src/types/index.ts
@@ -185,6 +185,12 @@ type RouterTransformationResponse = {
   statTags?: object;
 };
 
+type SourceTransformationEvent = {
+  headers?: Record<string, string>;
+  query_params?: Record<string, string>;
+  [key: string]: any;
+};
+
 type SourceTransformationOutput = {
   batch: RudderMessage[];
 };
@@ -360,6 +366,7 @@ export {
   RouterTransformationRequestData,
   RouterTransformationResponse,
   RudderMessage,
+  SourceTransformationEvent,
   SourceTransformationResponse,
   UserDeletionRequest,
   UserDeletionResponse,

diff --git a/src/v0/util/index.js b/src/v0/util/index.js
@@ -1168,7 +1168,7 @@ const getDestinationExternalIDInfoForRetl = (message, destination) => {
   if (externalIdArray) {
     externalIdArray.forEach((extIdObj) => {
       const { type, id } = extIdObj;
-      if (type && type.includes(`${destination}-`)) {
+      if (type?.includes(`${destination}-`)) {
         destinationExternalId = id;
         objectType = type.replace(`${destination}-`, '');
         identifierType = extIdObj.identifierType;
@@ -1195,7 +1195,7 @@ const getDestinationExternalIDObjectForRetl = (message, destination) => {
     // some stops the execution when the element is found
     externalIdArray.some((extIdObj) => {
       const { type } = extIdObj;
-      if (type && type.includes(`${destination}-`)) {
+      if (type?.includes(`${destination}-`)) {
         obj = extIdObj;
         return true;
       }