feat: capture router success/failure metrics (#2279)

feat: capture router failure metric Co-authored-by: Ujjwal Abhishek <[email protected]>
rudderlabs · Jun 20, 2023 · 7d4a9b2 · 7d4a9b2
1 parent 9faa41a
commit 7d4a9b2
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 17 deletions.
diff --git a/src/services/destination/cdkV2Integration.ts b/src/services/destination/cdkV2Integration.ts
@@ -120,23 +120,16 @@ export default class CDKV2DestinationService implements IntegrationDestinationSe
             destInputArray[0].metadata.workspaceId,
             tags.FEATURES.ROUTER,
           );
+          metaTo.metadata = destInputArray[0].metadata;
           try {
             const doRouterTransformationResponse: RouterTransformationResponse[] =
               await processCdkV2Workflow(destinationType, destInputArray, tags.FEATURES.ROUTER);
-
-            stats.increment('event_transform_success', {
-              destType: destinationType,
-              module: tags.MODULES.DESTINATION,
-              destinationId: destInputArray[0].metadata.destinationId,
-              workspaceId: destInputArray[0].metadata.workspaceId,
-              feature: tags.FEATURES.ROUTER,
-              implementation: tags.IMPLEMENTATIONS.CDK_V2,
-            });
-
             return DestinationPostTransformationService.handleRouterTransformSuccessEvents(
               doRouterTransformationResponse,
               undefined,
               metaTo,
+              tags.IMPLEMENTATIONS.CDK_V2,
+              destinationType.toUpperCase(),
             );
           } catch (error: any) {
             metaTo.metadatas = destInputArray.map((input) => input.metadata);
@@ -145,9 +138,6 @@ export default class CDKV2DestinationService implements IntegrationDestinationSe
                 error,
                 metaTo,
               );
-
-            stats.increment('event_transform_failure', metaTo.errorDetails);
-
             return [erroredResp];
           }
         },

diff --git a/src/services/destination/nativeIntegration.ts b/src/services/destination/nativeIntegration.ts
@@ -105,10 +105,13 @@ export default class NativeIntegrationDestinationService implements IntegrationD
         try {
           const doRouterTransformationResponse: RouterTransformationResponse[] =
             await destHandler.processRouterDest(destInputArray);
+          metaTO.metadata = destInputArray[0].metadata;
           return DestinationPostTransformationService.handleRouterTransformSuccessEvents(
             doRouterTransformationResponse,
             destHandler,
             metaTO,
+            tags.IMPLEMENTATIONS.NATIVE,
+            destinationType.toUpperCase(),
           );
         } catch (error: any) {
           metaTO.metadatas = destInputArray.map((input) => input.metadata);

diff --git a/src/services/destination/postTransformation.ts b/src/services/destination/postTransformation.ts
@@ -12,6 +12,8 @@ import {
 } from '../../types/index';
 import { generateErrorObject } from '../../v0/util';
 import ErrorReportingService from '../errorReporting';
+import tags from '../../v0/util/tags';
+import stats from '../../util/stats';
 
 export default class DestinationPostTransformationService {
   public static handleProcessorTransformSucessEvents(
@@ -63,27 +65,42 @@ export default class DestinationPostTransformationService {
     transformedPayloads: RouterTransformationResponse[],
     destHandler: any,
     metaTO: MetaTransferObject,
+    implementation: string,
+    destinationType: string,
   ): RouterTransformationResponse[] {
     const resultantPayloads: RouterTransformationResponse[] = cloneDeep(transformedPayloads);
     resultantPayloads.forEach((resultantPayload) => {
       if (resultantPayload.batchedRequest && resultantPayload.batchedRequest.userId) {
         resultantPayload.batchedRequest.userId = `${resultantPayload.batchedRequest.userId}`;
       }
     });
+
     if (destHandler?.processMetadataForRouter) {
       return resultantPayloads.map((resultantPayload) => {
         resultantPayload.metadata = destHandler.processMetadataForRouter(resultantPayload);
         return resultantPayload;
       });
     }
-    resultantPayloads
-      .filter((resp) => 'error' in resp && isObject(resp.statTags) && !isEmpty(resp.statTags))
-      .forEach((resp) => {
+
+    resultantPayloads.forEach((resp) => {
+      if ('error' in resp && isObject(resp.statTags) && !isEmpty(resp.statTags)) {
         resp.statTags = {
           ...resp.statTags,
           ...metaTO.errorDetails,
         };
-      });
+        stats.increment('event_transform_failure', metaTO.errorDetails);
+      } else {
+        stats.increment('event_transform_success', {
+          destType: destinationType,
+          module: tags.MODULES.DESTINATION,
+          implementation,
+          feature: tags.FEATURES.ROUTER,
+          destinationId: metaTO.metadata?.destinationId,
+          workspaceId: metaTO.metadata?.workspaceId,
+        });
+      }
+    });
+
     return resultantPayloads;
   }
 
@@ -100,6 +117,7 @@ export default class DestinationPostTransformationService {
       statTags: errObj.statTags,
     } as RouterTransformationResponse;
     ErrorReportingService.reportError(error, metaTO.errorContext, resp);
+    stats.increment('event_transform_failure', metaTO.errorDetails);
     return resp;
   }