fix: enhance code coverage

rudderlabs · Mar 11, 2024 · 7cf683b · 7cf683b
1 parent 1ff8127
commit 7cf683b
Show file tree

Hide file tree

Showing 4 changed files with 328 additions and 7 deletions.
diff --git a/src/v0/destinations/facebook_pixel/transform.test.js b/src/v0/destinations/facebook_pixel/transform.test.js
@@ -24,6 +24,23 @@ const getTestMessage = () => {
   return message;
 };
 
+const getTestMessageWithoutProductIdAndCategory = () => {
+  let message = {
+    properties: {
+      currency: 'CAD',
+      quantity: 1,
+      price: 24.75,
+      value: 30,
+      name: 'my product 1',
+      testDimension: true,
+      testMetric: true,
+      position: 4.5,
+      query: 'HDMI Cable',
+    },
+  };
+  return message;
+};
+
 const getTestCategoryToContent = () => {
   let categoryToContent = [
     {
@@ -52,6 +69,17 @@ describe('Unit test cases for facebook_pixel handle search', () => {
     expect(handleSearch(getTestMessage())).toEqual(expectedOutput);
   });
 
+  it('should return content with content_ids and content fields as empty array', async () => {
+    const expectedOutput = {
+      content_ids: [],
+      content_category: '',
+      value: 30,
+      search_string: 'HDMI Cable',
+      contents: [],
+    };
+    expect(handleSearch(getTestMessageWithoutProductIdAndCategory())).toEqual(expectedOutput);
+  });
+
   it("mapping 'product_id' with contentId", async () => {
     let message = getTestMessage();
     message.properties.product_id = 'prd-123';

diff --git a/test/integrations/destinations/facebook_pixel/processor/ecommTestData.ts b/test/integrations/destinations/facebook_pixel/processor/ecommTestData.ts
@@ -1070,4 +1070,51 @@ export const ecommTestData: ProcessorTestData[] = [
       },
     },
   },
+  {
+    id: 'facebook_pixel-ecomm-test-12',
+    name: 'facebook_pixel',
+    description:
+      'Track call : product list viewed event call with properties without product array and revenue as string',
+    scenario: 'ecommerce',
+    successCriteria:
+      'Error : It should throw an error as revenue is not a number and should not be sent to the destination',
+    feature: 'processor',
+    module: 'destination',
+    version: 'v0',
+    input: {
+      request: {
+        body: [
+          {
+            message: generateTrackPayload({
+              event: 'product list viewed',
+              properties: { ...commonPropertiesWithoutProductArray, value: '$20' },
+              context: {
+                traits: commonUserTraits,
+              },
+              timestamp: commonTimestamp,
+            }),
+            metadata: generateMetadata(1),
+            destination: commonDestination,
+          },
+        ],
+      },
+    },
+    output: {
+      response: {
+        status: 200,
+        body: [
+          {
+            error: 'Revenue could not be converted to number',
+            metadata: generateMetadata(1),
+            statTags: {
+              ...commonStatTags,
+              destinationId: 'default-destinationId',
+              workspaceId: 'default-workspaceId',
+            },
+            statusCode: 400,
+          },
+        ],
+      },
+    },
+  },
 ];
diff --git a/test/integrations/destinations/facebook_pixel/processor/pageScreenTestData.ts b/test/integrations/destinations/facebook_pixel/processor/pageScreenTestData.ts
@@ -515,7 +515,23 @@ export const pageScreenTestData: ProcessorTestData[] = [
               params: {},
               FORM: {
                 data: [
-                  '{"user_data":{"external_id":"470582f368e5aeec2cf487decd1e125b7d265e8b0b06b74a25e999e93bfb699f"},"event_name":"PageView","event_time":1697297576,"event_source_url":"jkl","action_source":"website","custom_data":{"path":"/abc","referrer":"xyz","search":"def","title":"ghi","url":"jkl"}}',
+                  JSON.stringify({
+                    user_data: {
+                      external_id:
+                        '470582f368e5aeec2cf487decd1e125b7d265e8b0b06b74a25e999e93bfb699f',
+                    },
+                    event_name: 'PageView',
+                    event_time: 1697297576,
+                    event_source_url: 'jkl',
+                    action_source: 'website',
+                    custom_data: {
+                      path: '/abc',
+                      referrer: 'xyz',
+                      search: 'def',
+                      title: 'ghi',
+                      url: 'jkl',
+                    },
+                  }),
                 ],
               },
               files: {},
@@ -582,7 +598,23 @@ export const pageScreenTestData: ProcessorTestData[] = [
               params: {},
               FORM: {
                 data: [
-                  '{"user_data":{"external_id":"470582f368e5aeec2cf487decd1e125b7d265e8b0b06b74a25e999e93bfb699f"},"event_name":"PageView","event_time":1697297576,"event_source_url":"jkl","action_source":"website","custom_data":{"path":"/abc","referrer":"xyz","search":"def","title":"ghi","url":"jkl"}}',
+                  JSON.stringify({
+                    user_data: {
+                      external_id:
+                        '470582f368e5aeec2cf487decd1e125b7d265e8b0b06b74a25e999e93bfb699f',
+                    },
+                    event_name: 'PageView',
+                    event_time: 1697297576,
+                    event_source_url: 'jkl',
+                    action_source: 'website',
+                    custom_data: {
+                      path: '/abc',
+                      referrer: 'xyz',
+                      search: 'def',
+                      title: 'ghi',
+                      url: 'jkl',
+                    },
+                  }),
                 ],
               },
               files: {},