feat: google ads v14 upgrade (#2578)

rudderlabs · Sep 19, 2023 · 735aac1 · 735aac1
1 parent 46c4ccc
commit 735aac1
Show file tree

Hide file tree

Showing 17 changed files with 96 additions and 96 deletions.
diff --git a/src/v0/destinations/google_adwords_enhanced_conversions/config.js b/src/v0/destinations/google_adwords_enhanced_conversions/config.js
@@ -1,6 +1,6 @@
 const { getMappingConfig } = require('../../util');
 
-const BASE_ENDPOINT = 'https://googleads.googleapis.com/v13/customers';
+const BASE_ENDPOINT = 'https://googleads.googleapis.com/v14/customers';
 
 const CONFIG_CATEGORIES = {
   TRACK_CONFIG: { type: 'track', name: 'trackConfig' },

diff --git a/src/v0/destinations/google_adwords_offline_conversions/config.js b/src/v0/destinations/google_adwords_offline_conversions/config.js
@@ -1,6 +1,6 @@
 const { getMappingConfig } = require('../../util');
 
-const API_VERSION = 'v13';
+const API_VERSION = 'v14';
 
 const BASE_ENDPOINT = `https://googleads.googleapis.com/${API_VERSION}/customers/:customerId`;
 

diff --git a/src/v0/destinations/google_adwords_offline_conversions/utils.test.js b/src/v0/destinations/google_adwords_offline_conversions/utils.test.js
@@ -161,7 +161,7 @@ describe('getExisitingUserIdentifier util tests', () => {
 describe('getClickConversionPayloadAndEndpoint util tests', () => {
   it('getClickConversionPayloadAndEndpoint flow check when default field identifier is present', () => {
     let expectedOutput = {
-      endpoint: 'https://googleads.googleapis.com/v13/customers/9625812972:uploadClickConversions',
+      endpoint: 'https://googleads.googleapis.com/v14/customers/9625812972:uploadClickConversions',
       payload: {
         conversions: [
           {
@@ -187,7 +187,7 @@ describe('getClickConversionPayloadAndEndpoint util tests', () => {
     delete fittingPayload.traits.email;
     delete fittingPayload.properties.email;
     let expectedOutput = {
-      endpoint: 'https://googleads.googleapis.com/v13/customers/9625812972:uploadClickConversions',
+      endpoint: 'https://googleads.googleapis.com/v14/customers/9625812972:uploadClickConversions',
       payload: {
         conversions: [
           {
@@ -215,7 +215,7 @@ describe('getClickConversionPayloadAndEndpoint util tests', () => {
     delete fittingPayload.traits.phone;
     delete fittingPayload.properties.email;
     let expectedOutput = {
-      endpoint: 'https://googleads.googleapis.com/v13/customers/9625812972:uploadClickConversions',
+      endpoint: 'https://googleads.googleapis.com/v14/customers/9625812972:uploadClickConversions',
       payload: {
         conversions: [
           {
@@ -251,7 +251,7 @@ describe('getClickConversionPayloadAndEndpoint util tests', () => {
       },
     ];
     let expectedOutput = {
-      endpoint: 'https://googleads.googleapis.com/v13/customers/9625812972:uploadClickConversions',
+      endpoint: 'https://googleads.googleapis.com/v14/customers/9625812972:uploadClickConversions',
       payload: {
         conversions: [
           {

diff --git a/src/v0/destinations/google_adwords_remarketing_lists/config.js b/src/v0/destinations/google_adwords_remarketing_lists/config.js
@@ -1,6 +1,6 @@
 const { getMappingConfig } = require('../../util');
 
-const BASE_ENDPOINT = 'https://googleads.googleapis.com/v13/customers';
+const BASE_ENDPOINT = 'https://googleads.googleapis.com/v14/customers';
 const CONFIG_CATEGORIES = {
   AUDIENCE_LIST: { type: 'audienceList', name: 'offlineDataJobs' },
   ADDRESSINFO: { type: 'addressInfo', name: 'addressInfo' },

diff --git a/test/__mocks__/data/google_adwords_offline_conversion/response.json b/test/__mocks__/data/google_adwords_offline_conversion/response.json
@@ -1,17 +1,17 @@
 {
-  "https://googleads.googleapis.com/v13/customers/11122233331/offlineUserDataJobs:create": {
+  "https://googleads.googleapis.com/v14/customers/11122233331/offlineUserDataJobs:create": {
     "data": {
       "resourceName": "customers/111-222-3333/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID_FOR_ADD_FAILURE"
     },
     "status": 200
   },
-  "https://googleads.googleapis.com/v13/customers/1112223333/offlineUserDataJobs:create": {
+  "https://googleads.googleapis.com/v14/customers/1112223333/offlineUserDataJobs:create": {
     "data": {
       "resourceName": "customers/111-222-3333/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID"
     },
     "status": 200
   },
-  "https://googleads.googleapis.com/v13/customers/customerid/offlineUserDataJobs:create": {
+  "https://googleads.googleapis.com/v14/customers/customerid/offlineUserDataJobs:create": {
     "status": 401,
     "data": {
       "error": {
@@ -21,11 +21,11 @@
       }
     }
   },
-  "https://googleads.googleapis.com/v13/customers/1112223333/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID:addOperations": {
+  "https://googleads.googleapis.com/v14/customers/1112223333/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID:addOperations": {
     "status": 200,
     "data": {}
   },
-  "https://googleads.googleapis.com/v13/customers/11122233331/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID_FOR_ADD_FAILURE:addOperations": {
+  "https://googleads.googleapis.com/v14/customers/11122233331/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID_FOR_ADD_FAILURE:addOperations": {
     "status": 400,
     "data": {
       "error": {
@@ -34,7 +34,7 @@
         "status": "INVALID_ARGUMENT",
         "details": [
           {
-            "@type": "type.googleapis.com/google.ads.googleads.v13.errors.GoogleAdsFailure",
+            "@type": "type.googleapis.com/google.ads.googleads.v14.errors.GoogleAdsFailure",
             "errors": [
               {
                 "errorCode": {
@@ -67,13 +67,13 @@
       }
     }
   },
-  "https://googleads.googleapis.com/v13/customers/1112223333/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID:run": {
+  "https://googleads.googleapis.com/v14/customers/1112223333/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID:run": {
     "status": 200,
     "data": {
       "name": "customers/111-222-3333/operations/abcd="
     }
   },
-  "https://googleads.googleapis.com/v13/customers/customerid/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID_ADD_FAILURE:addOperations": {
+  "https://googleads.googleapis.com/v14/customers/customerid/offlineUserDataJobs/OFFLINE_USER_DATA_JOB_ID_ADD_FAILURE:addOperations": {
     "status": 400,
     "data": {
       "error": {
@@ -82,7 +82,7 @@
         "status": "INVALID_ARGUMENT",
         "details": [
           {
-            "@type": "type.googleapis.com/google.ads.googleads.v13.errors.GoogleAdsFailure",
+            "@type": "type.googleapis.com/google.ads.googleads.v14.errors.GoogleAdsFailure",
             "errors": [
               {
                 "errorCode": {

diff --git a/test/__mocks__/data/google_adwords_remarketing_lists/proxy_response.json b/test/__mocks__/data/google_adwords_remarketing_lists/proxy_response.json
@@ -1,23 +1,23 @@
 {
-  "https://googleads.googleapis.com/v13/customers/7693729833/offlineUserDataJobs:create": {
+  "https://googleads.googleapis.com/v14/customers/7693729833/offlineUserDataJobs:create": {
     "status": 200,
     "data": {
       "resourceName": "customers/9249589672/offlineUserDataJobs/18025019461"
     }
   },
-  "https://googleads.googleapis.com/v13/customers/7693729833/offlineUserDataJobs/18025019461:addOperations": {
+  "https://googleads.googleapis.com/v14/customers/7693729833/offlineUserDataJobs/18025019461:addOperations": {
     "status": 200
   },
-  "https://googleads.googleapis.com/v13/customers/7693729833/offlineUserDataJobs/18025019461:run": {
+  "https://googleads.googleapis.com/v14/customers/7693729833/offlineUserDataJobs/18025019461:run": {
     "status": 200
   },
-  "https://googleads.googleapis.com/v13/customers/7693729834/offlineUserDataJobs:create": {
+  "https://googleads.googleapis.com/v14/customers/7693729834/offlineUserDataJobs:create": {
     "status": 200,
     "data": {
       "resourceName": "customers/9249589672/offlineUserDataJobs/18025019462"
     }
   },
-  "https://googleads.googleapis.com/v13/customers/7693729834/offlineUserDataJobs/18025019462:addOperations": {
+  "https://googleads.googleapis.com/v14/customers/7693729834/offlineUserDataJobs/18025019462:addOperations": {
     "response": {
       "data": {
         "error": {
@@ -60,7 +60,7 @@
       "status": 400
     }
   },
-  "https://googleads.googleapis.com/v13/customers/1234567890/googleAds:searchStream": {
+  "https://googleads.googleapis.com/v14/customers/1234567890/googleAds:searchStream": {
     "response": {
       "data": [
         {
@@ -74,11 +74,11 @@
       "status": 401
     }
   },
-  "https://googleads.googleapis.com/v13/customers/1234567899/googleAds:searchStream": {
+  "https://googleads.googleapis.com/v14/customers/1234567899/googleAds:searchStream": {
     "response": "",
     "code": "ECONNREFUSED"
   },
-  "https://googleads.googleapis.com/v13/customers/1234567891/googleAds:searchStream": {
+  "https://googleads.googleapis.com/v14/customers/1234567891/googleAds:searchStream": {
     "data": [
       {
         "results": [
@@ -95,7 +95,7 @@
     ],
     "status": 200
   },
-  "https://googleads.googleapis.com/v13/customers/1234567891:uploadConversionAdjustments": {
+  "https://googleads.googleapis.com/v14/customers/1234567891:uploadConversionAdjustments": {
     "data": [
       {
         "adjustmentType": "ENHANCEMENT",

diff --git a/test/__tests__/data/google_adwords_enhanced_conversions_output.json b/test/__tests__/data/google_adwords_enhanced_conversions_output.json
@@ -3,7 +3,7 @@
     "version": "1",
     "type": "REST",
     "method": "POST",
-    "endpoint": "https://googleads.googleapis.com/v13/customers/1234567890:uploadConversionAdjustments",
+    "endpoint": "https://googleads.googleapis.com/v14/customers/1234567890:uploadConversionAdjustments",
     "headers": {
       "Authorization": "Bearer abcd1234",
       "Content-Type": "application/json",
@@ -91,7 +91,7 @@
     "version": "1",
     "type": "REST",
     "method": "POST",
-    "endpoint": "https://googleads.googleapis.com/v13/customers/1234567890:uploadConversionAdjustments",
+    "endpoint": "https://googleads.googleapis.com/v14/customers/1234567890:uploadConversionAdjustments",
     "headers": {
       "Authorization": "Bearer abcd1234",
       "Content-Type": "application/json",
@@ -204,7 +204,7 @@
     "version": "1",
     "type": "REST",
     "method": "POST",
-    "endpoint": "https://googleads.googleapis.com/v13/customers/1234567890:uploadConversionAdjustments",
+    "endpoint": "https://googleads.googleapis.com/v14/customers/1234567890:uploadConversionAdjustments",
     "headers": {
       "Authorization": "Bearer abcd1234",
       "Content-Type": "application/json",
@@ -260,7 +260,7 @@
     "version": "1",
     "type": "REST",
     "method": "POST",
-    "endpoint": "https://googleads.googleapis.com/v13/customers/1234567890:uploadConversionAdjustments",
+    "endpoint": "https://googleads.googleapis.com/v14/customers/1234567890:uploadConversionAdjustments",
     "headers": {
       "Authorization": "Bearer abcd1234",
       "Content-Type": "application/json",

diff --git a/test/__tests__/data/google_adwords_enhanced_conversions_proxy_input.json b/test/__tests__/data/google_adwords_enhanced_conversions_proxy_input.json
@@ -3,7 +3,7 @@
     "version": "1",
     "type": "REST",
     "method": "POST",
-    "endpoint": "https://googleads.googleapis.com/v13/customers/1234567890:uploadConversionAdjustments",
+    "endpoint": "https://googleads.googleapis.com/v14/customers/1234567890:uploadConversionAdjustments",
     "headers": {
       "Authorization": "Bearer abcd1234",
       "Content-Type": "application/json",
@@ -56,7 +56,7 @@
     "version": "1",
     "type": "REST",
     "method": "POST",
-    "endpoint": "https://googleads.googleapis.com/v13/customers/1234567899:uploadConversionAdjustments",
+    "endpoint": "https://googleads.googleapis.com/v14/customers/1234567899:uploadConversionAdjustments",
     "headers": {
       "Authorization": "Bearer abcd1234",
       "Content-Type": "application/json",
@@ -109,7 +109,7 @@
     "version": "1",
     "type": "REST",
     "method": "POST",
-    "endpoint": "https://googleads.googleapis.com/v13/customers/1234567891:uploadConversionAdjustments",
+    "endpoint": "https://googleads.googleapis.com/v14/customers/1234567891:uploadConversionAdjustments",
     "headers": {
       "Authorization": "Bearer abcd1234",
       "Content-Type": "application/json",

diff --git a/test/__tests__/data/google_adwords_enhanced_conversions_router_output.json b/test/__tests__/data/google_adwords_enhanced_conversions_router_output.json
@@ -4,7 +4,7 @@
       "version": "1",
       "type": "REST",
       "method": "POST",
-      "endpoint": "https://googleads.googleapis.com/v13/customers/1234567890:uploadConversionAdjustments",
+      "endpoint": "https://googleads.googleapis.com/v14/customers/1234567890:uploadConversionAdjustments",
       "headers": {
         "Authorization": "Bearer abcd1234",
         "Content-Type": "application/json",