fix: marketo bulk ignore null while checking data type mismatch (#3263)

rudderlabs · Apr 9, 2024 · 6e3274b · 6e3274b
1 parent 9c6b251
commit 6e3274b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/v0/destinations/marketo_bulk_upload/marketo_bulk_upload.util.test.js b/src/v0/destinations/marketo_bulk_upload/marketo_bulk_upload.util.test.js
@@ -514,7 +514,7 @@ describe('checkEventStatusViaSchemaMatching', () => {
   });
 
   // The function correctly handles events with null values.
-  it('should correctly handle events with null values', () => {
+  it('should ignore event properties with null values', () => {
     const event = {
       input: [
         {
@@ -537,8 +537,6 @@ describe('checkEventStatusViaSchemaMatching', () => {
 
     const result = checkEventStatusViaSchemaMatching(event, fieldSchemaMapping);
 
-    expect(result).toEqual({
-      job1: 'invalid id',
-    });
+    expect(result).toEqual({});
   });
 });
diff --git a/src/v0/destinations/marketo_bulk_upload/util.js b/src/v0/destinations/marketo_bulk_upload/util.js
@@ -3,6 +3,7 @@ const {
   RetryableError,
   NetworkError,
   TransformationError,
+  isDefinedAndNotNull,
 } = require('@rudderstack/integrations-lib');
 const { handleHttpRequest } = require('../../../adapters/network');
 const tags = require('../../util/tags');
@@ -360,7 +361,6 @@ const getFieldSchemaMap = async (accessToken, munchkinId) => {
       module: 'router',
     },
   );
-
   if (fieldSchemaMapping.response.errors) {
     handleCommonErrorResponse(
       fieldSchemaMapping,
@@ -411,7 +411,11 @@ const checkEventStatusViaSchemaMatching = (event, fieldMap) => {
       const expectedDataType = SCHEMA_DATA_TYPE_MAP[fieldMap[paramName]];
       const actualDataType = typeof paramValue;
 
-      if (!mismatchedFields[job_id] && actualDataType !== expectedDataType) {
+      if (
+        isDefinedAndNotNull(paramValue) &&
+        !mismatchedFields[job_id] &&
+        actualDataType !== expectedDataType
+      ) {
         mismatchedFields[job_id] = `invalid ${paramName}`;
       }
     });