fix: fb_error message for invalid type of property value

rudderlabs · Sep 26, 2023 · 69ab3f9 · 69ab3f9
1 parent 4f7cbc4
commit 69ab3f9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/src/v0/destinations/fb/transform.js b/src/v0/destinations/fb/transform.js
@@ -161,18 +161,20 @@ function sanityCheckPayloadForTypesAndModifications(updatedEvent) {
   return clonedUpdatedEvent;
 }
 
-function getCorrectedTypedValue(pathToKey, value, originalPath) {
+function getCorrectedTypedValue(pathToKey, value) {
   const type = eventPropToTypeMapping[pathToKey];
   // TODO: we should remove this eslint rule or comeup with a better way
   // eslint-disable-next-line valid-typeof
   if (typeof value === type) {
     return value;
   }
 
+  const mappingKey = Object.keys(eventPropsMapping).find(
+    (key) => eventPropsMapping[key] === pathToKey,
+  );
+
   throw new InstrumentationError(
-    `${
-      typeof originalPath === 'object' ? JSON.stringify(originalPath) : originalPath
-    } is not of valid type`,
+    `Value of ${mappingKey} is not of valid type. It should be of type ${type}`,
   );
 }
 
@@ -221,7 +223,6 @@ function processEventTypeGeneric(message, baseEvent, fbEventName) {
             updatedEvent.custom_events[0][fbEventPath][length] = getCorrectedTypedValue(
               fbEventPath,
               intendValue,
-              parentArray[length],
             );
             length += 1;
             count -= 1;
@@ -233,7 +234,7 @@ function processEventTypeGeneric(message, baseEvent, fbEventName) {
           set(
             updatedEvent.custom_events[0],
             fbEventPath,
-            getCorrectedTypedValue(fbEventPath, intendValue, rudderEventPath),
+            getCorrectedTypedValue(fbEventPath, intendValue),
           );
         }
       } else {

diff --git a/test/__tests__/data/fb_output.json b/test/__tests__/data/fb_output.json
@@ -3,10 +3,10 @@
     "message": "If properties.revenue is present, properties.currency is required."
   },
   {
-    "message": "{\"product_id\":123} is not of valid type"
+    "message": "Value of properties.products.sub.product_id is not of valid type. It should be of type string"
   },
   {
-    "message": "properties.revenue is not of valid type"
+    "message": "Value of properties.revenue is not of valid type. It should be of type number"
   },
   {
     "body": {
@@ -307,4 +307,4 @@
     "userId": "c82cbdff-e5be-4009-ac78-cdeea09ab4b1",
     "statusCode": 200
   }
-]
+]
diff --git a/test/__tests__/data/fb_router_output.json b/test/__tests__/data/fb_router_output.json
@@ -35,6 +35,6 @@
     },
     "batched": false,
     "statusCode": 400,
-    "error": "{\"product_id\":123} is not of valid type"
+    "error": "Value of properties.products.sub.product_id is not of valid type. It should be of type string"
   }
 ]