chore: refactor code and add tests

rudderlabs · Oct 20, 2023 · 6529776 · 6529776
1 parent dbe89bf
commit 6529776
Show file tree

Hide file tree

Showing 5 changed files with 831 additions and 11 deletions.
diff --git a/src/cdk/v2/destinations/ortto/procWorkflow.yaml b/src/cdk/v2/destinations/ortto/procWorkflow.yaml
@@ -84,7 +84,7 @@ steps:
             customEvent = event === .rsEventName ? .orttoEventName : null;
           )
           $.assert(customEvent, "Event names is not mapped");
-          customEvent = "act:cm:"+customEvent.trim().toLowerCase().replace(new RegExp('\\s+', 'g'),'-');
+          "act:cm:"+customEvent.trim().toLowerCase().replace(new RegExp('\\s+', 'g'),'-');
 
       - name: getAttributes
         template: |
@@ -101,8 +101,8 @@ steps:
             "activity_id": $.outputs.prepareTrackPayload.getTrimmedEvent,
             "attributes": $.outputs.prepareTrackPayload.getAttributes,
             "location": {"source_ip": .message.context.ip}
-          }
-          const trackPayoad = {   
+          };
+          {   
             "activities":[activityObj],
             "merge_by": ["str::ei", "str::email"]
           }
@@ -122,4 +122,4 @@ steps:
           "X-Api-Key": .destination.Config.privateApiKey,
           "Content-Type": "application/json"
         };
-      finalResponse = response;
+      response;
diff --git a/src/cdk/v2/destinations/ortto/rtWorkflow.yaml b/src/cdk/v2/destinations/ortto/rtWorkflow.yaml
@@ -16,8 +16,8 @@ steps:
     loopOverInput: true
   - name: successfulEvents
     template: |
-      $.outputs.transform#idx{ "output" in .}.({
-        "message": .output[],
+      $.outputs.transform#idx.output.({
+        "message": .[],
         "destination": ^ [idx].destination,
         "metadata": ^ [idx].metadata
       })[]
@@ -34,12 +34,14 @@ steps:
 
   - name: batchSuccessfulEvents
     description: Batches the successfulEvents using V3 API
+    condition: $.outputs.successfulEvents.length
     template: |
       let batches = $.batchEvents($.outputs.successfulEvents);
+      console.log("abc",JSON.stringify(batches,null,2))
       batches@batch.({
         "batchedRequest": {
           "body": {
-            "JSON": ~r batch.message,
+            "JSON": batch.message,
             "JSON_ARRAY": {},
             "XML": {},
             "FORM": {}
@@ -55,11 +57,14 @@ steps:
           "params": {},
           "files": {}
         },
-        "metadata": ~r batch.metadata,
+        "metadata": batch.metadata,
         "batched": true,
         "statusCode": 200,
-        "destination": ~r batch.destination
+        "destination": batch.destination
       })[];
+    else:
+      name: returnEmptyOuput
+      template: '[]'
 
   - name: finalPayload
     template: |

diff --git a/src/cdk/v2/destinations/ortto/utils.js b/src/cdk/v2/destinations/ortto/utils.js
@@ -27,7 +27,7 @@ const groupEventsByEndpoint = (events) => {
       const { destination, metadata } = result;
       const message = CommonUtils.toArray(result.message);
       message.forEach((msg) => {
-        const endpoint = Object.keys(eventMap).find((key) => msg.endpoint.includes(key));
+        const endpoint = Object.keys(eventMap).find((key) => msg.endpoint?.includes(key));
         if (endpoint) {
           eventMap[endpoint].push({ message: msg.body.JSON, destination, metadata });
         }

diff --git a/src/features.json b/src/features.json
@@ -57,6 +57,7 @@
     "BRAZE": true,
     "OPTIMIZELY_FULLSTACK": true,
     "TWITTER_ADS": true,
-    "CLEVERTAP": true
+    "CLEVERTAP": true,
+    "ORTTO": true
   }
 }