fix: send group_id as string in monday destination

rudderlabs · Apr 16, 2024 · 4952bd2 · 4952bd2
1 parent 1697641
commit 4952bd2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/v0/destinations/monday/util.js b/src/v0/destinations/monday/util.js
@@ -244,7 +244,7 @@ const populatePayload = (message, Config, boardDeatailsResponse) => {
       throw new InstrumentationError('Item name is required to create an item');
     }
     const groupId = getGroupId(groupTitle, boardDeatailsResponse.response?.data);
-    payload.query = `mutation { create_item (board_id: ${boardId}, group_id: ${JSON.stringify(groupId)} item_name: ${JSON.stringify(
+    payload.query = `mutation { create_item (board_id: ${boardId}, group_id: ${JSON.stringify(groupId)}, item_name: ${JSON.stringify(
       message.properties?.name,
     )}, column_values: ${JSON.stringify(columnValues)}) {id}}`;
   } else {

diff --git a/test/integrations/destinations/monday/processor/data.ts b/test/integrations/destinations/monday/processor/data.ts
@@ -827,7 +827,7 @@ export const data = [
               body: {
                 JSON: {
                   query:
-                    'mutation { create_item (board_id: 339283933, group_id: "group_title" item_name: "Task 1", column_values: "{\\"status\\":{\\"label\\":\\"Done\\"},\\"email\\":{\\"email\\":\\"[email protected]\\",\\"text\\":\\"emailId\\"}}") {id}}',
+                    'mutation { create_item (board_id: 339283933, group_id: "group_title", item_name: "Task 1", column_values: "{\\"status\\":{\\"label\\":\\"Done\\"},\\"email\\":{\\"email\\":\\"[email protected]\\",\\"text\\":\\"emailId\\"}}") {id}}',
                 },
                 JSON_ARRAY: {},
                 XML: {},
@@ -1188,7 +1188,7 @@ export const data = [
               body: {
                 JSON: {
                   query:
-                    'mutation { create_item (board_id: 339283933, group_id: "group_title" item_name: "Task 1", column_values: "{\\"status\\":{\\"label\\":\\"Done\\"},\\"email\\":{\\"email\\":\\"[email protected]\\",\\"text\\":\\"emailId\\"},\\"checkbox\\":{\\"checked\\":true},\\"numbers\\":\\"45\\",\\"text\\":\\"texting\\",\\"country\\":{\\"countryName\\":\\"Unites States\\",\\"countryCode\\":\\"US\\"},\\"location\\":{\\"address\\":\\"New York\\",\\"lat\\":\\"51.23\\",\\"lng\\":\\"35.3\\"},\\"phone\\":{\\"phone\\":\\"2626277272\\",\\"countryShortName\\":\\"US\\"},\\"rating\\":3,\\"link\\":{\\"url\\":\\"demo.com\\",\\"text\\":\\"websiteLink\\"},\\"long_text\\":{\\"text\\":\\"property description\\"},\\"world_clock\\":{\\"timezone\\":\\"America/New_York\\"}}") {id}}',
+                    'mutation { create_item (board_id: 339283933, group_id: "group_title", item_name: "Task 1", column_values: "{\\"status\\":{\\"label\\":\\"Done\\"},\\"email\\":{\\"email\\":\\"[email protected]\\",\\"text\\":\\"emailId\\"},\\"checkbox\\":{\\"checked\\":true},\\"numbers\\":\\"45\\",\\"text\\":\\"texting\\",\\"country\\":{\\"countryName\\":\\"Unites States\\",\\"countryCode\\":\\"US\\"},\\"location\\":{\\"address\\":\\"New York\\",\\"lat\\":\\"51.23\\",\\"lng\\":\\"35.3\\"},\\"phone\\":{\\"phone\\":\\"2626277272\\",\\"countryShortName\\":\\"US\\"},\\"rating\\":3,\\"link\\":{\\"url\\":\\"demo.com\\",\\"text\\":\\"websiteLink\\"},\\"long_text\\":{\\"text\\":\\"property description\\"},\\"world_clock\\":{\\"timezone\\":\\"America/New_York\\"}}") {id}}',
                 },
                 JSON_ARRAY: {},
                 XML: {},

diff --git a/test/integrations/destinations/monday/router/data.ts b/test/integrations/destinations/monday/router/data.ts
@@ -159,7 +159,7 @@ export const data = [
                 body: {
                   JSON: {
                     query:
-                      'mutation { create_item (board_id: 339283933, group_id: "group_title" item_name: "Task 1", column_values: "{\\"status\\":{\\"label\\":\\"Done\\"},\\"email\\":{\\"email\\":\\"[email protected]\\",\\"text\\":\\"emailId\\"}}") {id}}',
+                      'mutation { create_item (board_id: 339283933, group_id: "group_title", item_name: "Task 1", column_values: "{\\"status\\":{\\"label\\":\\"Done\\"},\\"email\\":{\\"email\\":\\"[email protected]\\",\\"text\\":\\"emailId\\"}}") {id}}',
                   },
                   JSON_ARRAY: {},
                   XML: {},