fix: bug fix for track event

rudderlabs · Nov 27, 2023 · 46d3f1c · 46d3f1c
1 parent 9eda50e
commit 46d3f1c
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/v0/destinations/sfmc/transform.js b/src/v0/destinations/sfmc/transform.js
@@ -3,6 +3,8 @@ const {
   NetworkError,
   ConfigurationError,
   InstrumentationError,
+  isDefinedAndNotNull,
+  isEmpty,
 } = require('@rudderstack/integrations-lib');
 const myAxios = require('../../../util/myAxios');
 const { EventType } = require('../../../constants');
@@ -17,7 +19,6 @@ const {
   flattenJson,
   toTitleCase,
   getHashFromArray,
-  isEmpty,
   simpleProcessRouterDest,
 } = require('../../util');
 const {
@@ -224,7 +225,13 @@ const responseBuilderSimple = async (message, category, destination) => {
     throw new ConfigurationError('Creating or updating contacts is disabled');
   }
 
-  if (category.type === 'track' && hashMapExternalKey[message.event.toLowerCase()]) {
+  if (category.type === 'track') {
+    if (isEmpty(message.event)) {
+      throw new ConfigurationError('Event name is required for this track events');
+    }
+    if (!isDefinedAndNotNull(hashMapExternalKey[message.event.toLowerCase()])) {
+      throw new ConfigurationError('Event not mapped for this track call');
+    }
     return responseBuilderForInsertData(
       message,
       hashMapExternalKey[message.event.toLowerCase()],
@@ -237,7 +244,7 @@ const responseBuilderSimple = async (message, category, destination) => {
     );
   }
 
-  throw new ConfigurationError('Event not mapped for this track call');
+  throw new ConfigurationError('Event type not supported');
 };
 
 const processEvent = async (message, destination) => {