chore: small fix for undefined userDefinedTemplate

rudderlabs · Feb 12, 2024 · 3d370db · 3d370db
1 parent 8c467c2
commit 3d370db
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/v0/destinations/am/transform.js b/src/v0/destinations/am/transform.js
@@ -615,7 +615,7 @@ const processSingleMessage = (message, destination) => {
     case EventType.PAGE:
       if (useUserDefinedPageEventName) {
         const getMessagePath = userProvidedPageEventString
-          .substring(
+          ?.substring(
             userProvidedPageEventString.indexOf('{') + 2,
             userProvidedPageEventString.indexOf('}'),
           )
@@ -624,7 +624,7 @@ const processSingleMessage = (message, destination) => {
           userProvidedPageEventString.trim() === ''
             ? name
             : userProvidedPageEventString
-                .trim()
+                ?.trim()
                 .replaceAll(/{{([^{}]+)}}/g, get(message, getMessagePath));
       } else {
         evType = `Viewed ${name || get(message, CATEGORY_KEY) || ''} Page`;
@@ -705,7 +705,7 @@ const processSingleMessage = (message, destination) => {
   // putting a check for evType as there some cases like page name is not present and teamplte depends on page name only.
   if (!isDefinedAndNotNull(evType)) {
     throw new InstrumentationError(
-      'Event type not present. Please send event type. If you are sending page/screen call, please provide the name',
+      'Event type not present. If you are sending page/screen call with custom name, please provide the name',
     );
   }
   return responseBuilderSimple(

diff --git a/test/integrations/destinations/am/processor/data.ts b/test/integrations/destinations/am/processor/data.ts
@@ -11352,7 +11352,7 @@ export const data = [
               Config: {
                 apiKey: 'abcde',
                 useUserDefinedPageEventName: true,
-                userProvidedPageEventString: undefined,
+                userProvidedPageEventString: '',
               },
             },
           },
@@ -11366,7 +11366,7 @@ export const data = [
           {
             statusCode: 400,
             error:
-              'Event type not present. Please send event type. If you are sending page/screen call, please provide the name',
+              'Event type not present. If you are sending page/screen call with custom name, please provide the name',
             statTags: {
               errorCategory: 'dataValidation',
               errorType: 'instrumentation',