feat: reviw comments addressed

rudderlabs · Jan 30, 2024 · 300e50c · 300e50c
1 parent 62dfa32
commit 300e50c
Show file tree

Hide file tree

Showing 6 changed files with 54 additions and 117 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -64,7 +64,7 @@
     "@koa/router": "^12.0.0",
     "@ndhoule/extend": "^2.0.0",
     "@pyroscope/nodejs": "^0.2.6",
-    "@rudderstack/integrations-lib": "^0.1.8",
+    "@rudderstack/integrations-lib": "file:../rudder-integrations-lib",
     "@rudderstack/workflow-engine": "^0.6.9",
     "ajv": "^8.12.0",
     "ajv-draft-04": "^1.0.0",

diff --git a/src/v0/util/facebookUtils/networkHandler.js b/src/v0/util/facebookUtils/networkHandler.js
@@ -2,7 +2,7 @@ const { isEmpty } = require('lodash');
 const get = require('get-value');
 const {
   NetworkError,
-  UnauthorizedError,
+  ConfigurationAuthError,
   isDefinedAndNotNull,
 } = require('@rudderstack/integrations-lib');
 const {
@@ -252,10 +252,7 @@ const errorResponseHandler = (destResponse) => {
   const { error } = response;
   const { status, errorMessage, stats: errorStatTags } = getStatus(error);
   if (isDefinedAndNotNull(errorStatTags) && errorStatTags?.errorType === 'accessTokenExpired') {
-    throw new UnauthorizedError(`${errorMessage}`, status, {
-      ...response,
-      status: destResponse.status,
-    });
+    throw new ConfigurationAuthError(`${errorMessage}`);
   }
   throw new NetworkError(
     `${errorMessage || error.message || 'Unknown failure during response transformation'}`,

diff --git a/test/integrations/destinations/facebook_pixel/dataDelivery/data.ts b/test/integrations/destinations/facebook_pixel/dataDelivery/data.ts
@@ -41,22 +41,14 @@ export const data = [
           output: {
             status: 400,
             message: 'Invalid OAuth 2.0 access token',
-            destinationResponse: {
-              error: {
-                message: 'The access token could not be decrypted',
-                type: 'OAuthException',
-                code: 190,
-                fbtrace_id: 'fbpixel_trace_id',
-              },
-              status: 500,
-            },
+            destinationResponse: '',
             statTags: {
               destType: 'FACEBOOK_PIXEL',
-              errorCategory: 'network',
+              errorCategory: 'dataValidation',
               destinationId: 'Non-determininable',
               workspaceId: 'Non-determininable',
-              errorType: 'aborted',
-              meta: 'unauthorized',
+              errorType: 'configuration',
+              meta: 'accessTokenExpired',
               feature: 'dataDelivery',
               implementation: 'native',
               module: 'destination',

diff --git a/test/integrations/destinations/fb/dataDelivery/data.ts b/test/integrations/destinations/fb/dataDelivery/data.ts
@@ -55,22 +55,14 @@ export const data = [
           output: {
             status: 400,
             message: 'Invalid OAuth 2.0 access token',
-            destinationResponse: {
-              error: {
-                message: 'The access token could not be decrypted',
-                type: 'OAuthException',
-                code: 190,
-                fbtrace_id: 'fbpixel_trace_id',
-              },
-              status: 500,
-            },
+            destinationResponse: '',
             statTags: {
               destType: 'FB',
-              errorCategory: 'network',
+              errorCategory: 'dataValidation',
               destinationId: 'Non-determininable',
               workspaceId: 'Non-determininable',
-              errorType: 'aborted',
-              meta: 'unauthorized',
+              errorType: 'configuration',
+              meta: 'accessTokenExpired',
               feature: 'dataDelivery',
               implementation: 'native',
               module: 'destination',

diff --git a/test/integrations/destinations/fb_custom_audience/dataDelivery/data.ts b/test/integrations/destinations/fb_custom_audience/dataDelivery/data.ts
@@ -574,7 +574,7 @@ export const data = [
   },
   {
     name: 'fb_custom_audience',
-    description: 'user addition failed due to unavailable audience error',
+    description: 'user addition failed due expired access token error',
     feature: 'dataDelivery',
     module: 'destination',
     version: 'v0',
@@ -614,24 +614,14 @@ export const data = [
         status: 400,
         body: {
           output: {
-            destinationResponse: {
-              error: {
-                message:
-                  'Error validating access token: Session has expired on Tuesday, 01-Aug-23 10:12:14 PDT. The current time is Sunday, 28-Jan-24 16:01:17 PST.',
-                type: 'OAuthException',
-                code: 190,
-                error_subcode: 463,
-                fbtrace_id: 'A3b8C6PpI-kdIOwPwV4PANi',
-              },
-              status: 400,
-            },
+            destinationResponse: '',
             message: 'Invalid OAuth 2.0 access token',
             statTags: {
               destType: 'FB_CUSTOM_AUDIENCE',
               destinationId: 'Non-determininable',
-              errorCategory: 'network',
-              errorType: 'aborted',
-              meta: 'unauthorized',
+              errorCategory: 'dataValidation',
+              errorType: 'configuration',
+              meta: 'accessTokenExpired',
               feature: 'dataDelivery',
               implementation: 'native',
               module: 'destination',