fix: test

src/cdk/v2/destinations/smartly/procWorkflow.yaml

@@ -23,7 +23,8 @@ steps:
   - name: preparePayload
     template: |
       const payload = $.removeUndefinedAndNullValues($.constructPayload(.message, $.TRACK_CONFIG));
-      $.context.payloadList = $.getPayloads(.message.event, .destination.Config, payload)
+      $.verifyAdInteractionTime(payload.ad_interaction_time);
+      $.context.payloadList = $.getPayloads(.message.event_name, .destination.Config, payload)
   - name: buildResponse
     template: |
       const response = $.buildResponseList($.context.payloadList)

src/cdk/v2/destinations/smartly/utils.js

@@ -1,5 +1,6 @@
 const { BatchUtils } = require('@rudderstack/workflow-engine');
 const { InstrumentationError } = require('@rudderstack/integrations-lib');
+const moment = require('moment');
 const config = require('./config');
 const {
   getHashFromArrayWithDuplicate,
@@ -31,6 +32,38 @@ const getPayloads = (event, Config, payload) => {
   return payloadLists;
 };
 
+const verifyAdInteractionTime = (adInteractionTime) => {
+  if (isDefinedAndNotNull(adInteractionTime)) {
+    let adInteractionTimeMoment;
+
+    // Handle both UNIX timestamps and UTC date strings
+    if (typeof adInteractionTime === 'number') {
+      adInteractionTimeMoment = moment.unix(adInteractionTime); // Parse as UNIX timestamp
+    } else {
+      adInteractionTimeMoment = moment.utc(adInteractionTime); // Parse as UTC date string
+    }
+
+    const currentMoment = moment.utc(); // Current time in UTC
+
+    // Calculate the time difference in days
+    const diffDaysPast = currentMoment.diff(adInteractionTimeMoment, 'days');
+    const diffDaysFuture = adInteractionTimeMoment.diff(currentMoment, 'days');
+
+    // Define the day range: 3 years (1095 days) in the past and 1 year (365 days) in the future
+    const maxDaysPast = 3 * 365 + 1; // 1095 days + 1 day for a leap year
+    const maxDaysFuture = 1 * 365 + 1; // 365 days + 1 day for a leap year
+
+    // Check if adInteractionTime is within the allowed range
+    const isWithinAllowedRange = diffDaysPast <= maxDaysPast && diffDaysFuture <= maxDaysFuture;
+
+    if (!isWithinAllowedRange) {
+      throw new InstrumentationError(
+        'ad_interaction_time must be within one year in the future and three years in the past.',
+      );
+    }
+  }
+};
+
 const buildResponseList = (payloadList) =>
   payloadList.map((payload) => {
     const response = defaultRequestConfig();
@@ -84,4 +117,4 @@ const batchResponseBuilder = (events) => {
   return response;
 };
 
-module.exports = { batchResponseBuilder, getPayloads, buildResponseList };
+module.exports = { batchResponseBuilder, getPayloads, buildResponseList, verifyAdInteractionTime };

src/cdk/v2/destinations/smartly/utils.test.js

@@ -0,0 +1,66 @@
+const moment = require('moment');
+const { InstrumentationError } = require('@rudderstack/workflow-engine');
+const { verifyAdInteractionTime } = require('./utils');
+
+describe('verifyAdInteractionTime', () => {
+  it('should pass when adInteractionTime is 2 years in the past (UNIX timestamp)', () => {
+    // 2 years ago from now
+    const adInteractionTime = moment().subtract(2, 'years').unix();
+    expect(() => verifyAdInteractionTime(adInteractionTime)).not.toThrow();
+  });
+
+  it('should pass when adInteractionTime is 10 months in the future (UNIX timestamp)', () => {
+    // 10 months in the future from now
+    const adInteractionTime = moment().add(10, 'months').unix();
+    expect(() => verifyAdInteractionTime(adInteractionTime)).not.toThrow();
+  });
+
+  it('should fail when adInteractionTime is 4 years in the past (UNIX timestamp)', () => {
+    // 4 years ago from now
+    const adInteractionTime = moment().subtract(4, 'years').unix();
+    expect(() => verifyAdInteractionTime(adInteractionTime)).toThrow(
+      'ad_interaction_time must be within one year in the future and three years in the past.',
+    );
+  });
+
+  it('should fail when adInteractionTime is 2 years in the future (UNIX timestamp)', () => {
+    // 2 years in the future from now
+    const adInteractionTime = moment().add(2, 'years').unix();
+    expect(() => verifyAdInteractionTime(adInteractionTime)).toThrow(
+      'ad_interaction_time must be within one year in the future and three years in the past.',
+    );
+  });
+
+  it('should pass when adInteractionTime is exactly 3 years in the past (UTC date string)', () => {
+    // Exactly 3 years ago from now
+    const adInteractionTime = moment.utc().subtract(3, 'years').toISOString();
+    expect(() => verifyAdInteractionTime(adInteractionTime)).not.toThrow();
+  });
+
+  it('should pass when adInteractionTime is exactly 1 year in the future (UTC date string)', () => {
+    // Exactly 1 year in the future from now
+    const adInteractionTime = moment.utc().add(1, 'year').toISOString();
+    expect(() => verifyAdInteractionTime(adInteractionTime)).not.toThrow();
+  });
+
+  it('should fail when adInteractionTime is 4 years in the past (UTC date string)', () => {
+    // 4 years ago from now
+    const adInteractionTime = moment.utc().subtract(4, 'years').toISOString();
+    expect(() => verifyAdInteractionTime(adInteractionTime)).toThrow(
+      'ad_interaction_time must be within one year in the future and three years in the past.',
+    );
+  });
+
+  it('should fail when adInteractionTime is 2 years in the future (UTC date string)', () => {
+    // 2 years in the future from now
+    const adInteractionTime = moment.utc().add(2, 'years').toISOString();
+    expect(() => verifyAdInteractionTime(adInteractionTime)).toThrow(
+      'ad_interaction_time must be within one year in the future and three years in the past.',
+    );
+  });
+
+  it('should not throw an error if adInteractionTime is null or undefined', () => {
+    expect(() => verifyAdInteractionTime(null)).not.toThrow();
+    expect(() => verifyAdInteractionTime(undefined)).not.toThrow();
+  });
+});

test/integrations/destinations/smartly/processor/data.ts

@@ -1,4 +1,9 @@
 import { trackTestData } from './track';
 import { validationFailures } from './validation';
 
-export const data = [...trackTestData, ...validationFailures];
+export const mockFns = (_) => {
+  // @ts-ignore
+  jest.useFakeTimers().setSystemTime(new Date('2024-02-01'));
+};
+
+export const data = [...trackTestData, ...validationFailures].map((d) => ({ ...d, mockFns }));

test/integrations/destinations/smartly/processor/track.ts

@@ -1,3 +1,5 @@
+const moment = require('moment');
+import { verifyAdInteractionTime } from '../../../../../src/cdk/v2/destinations/smartly/utils';
 import { destination } from '../commonConfig';
 
 export const trackTestData = [
@@ -13,11 +15,11 @@ export const trackTestData = [
           {
             destination,
             message: {
-              event: 'Add to cart',
+              event_name: 'Add to cart',
               properties: {
                 platform: 'meta',
-                ad_unit_id: 228287,
-                ad_interaction_time: '1650626278',
+                ad_unit_id: '228287',
+                ad_interaction_time: '1612137600',
                 email: '[email protected]',
               },
               type: 'track',
@@ -44,16 +46,16 @@ export const trackTestData = [
               version: '1',
               type: 'REST',
               method: 'POST',
-              endpoint: 'https://s2s.smartly.io/events',
+              endpoint: 'https://s2s.smartly.io/events/batch',
               headers: {},
               params: {},
               body: {
                 JSON: {
                   platform: 'meta',
-                  ad_unit_id: 228287,
-                  ad_interaction_time: '1650626278',
+                  ad_unit_id: '228287',
+                  ad_interaction_time: '1612137600',
                   conversions: '1',
-                  event: 'Add to cart',
+                  event_name: 'Add to cart',
                 },
                 JSON_ARRAY: {},
                 XML: {},

test/integrations/destinations/smartly/processor/validation.ts

@@ -17,13 +17,13 @@ export const validationFailures = [
             destination,
             message: {
               type: 'track',
-              event: 'product purchased',
+              event_name: 'product purchased',
               sentAt: '2021-01-25T16:12:02.048Z',
               userId: 'john123',
               properties: {
                 products: [{}],
                 ad_unit_id: '22123387',
-                ad_interaction_time: '1650626278',
+                ad_interaction_time: '1690867200',
               },
               integrations: {
                 All: true,
@@ -72,7 +72,7 @@ export const validationFailures = [
             destination,
             message: {
               type: 'group',
-              event: 'purchase',
+              event_name: 'purchase',
               sentAt: '2021-01-25T16:12:02.048Z',
               userId: 'john67',
               channel: 'mobile',
@@ -81,7 +81,7 @@ export const validationFailures = [
               properties: {
                 platform: 'snapchat',
                 ad_unit_id: '2653387',
-                ad_interaction_time: '1650646278',
+                ad_interaction_time: '1690867200',
               },
               anonymousId: 'anon_123',
               integrations: {
@@ -138,7 +138,7 @@ export const validationFailures = [
               properties: {
                 platform: 'snapchat',
                 ad_unit_id: '2653387',
-                ad_interaction_time: '1650646278',
+                ad_interaction_time: '1675094400',
               },
               anonymousId: 'anon_123',
               integrations: {