refactor: address review comments

rudderlabs · Jan 3, 2024 · 215e6b8 · 215e6b8
1 parent de15516
commit 215e6b8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/cdk/v2/destinations/the_trade_desk/utils.js b/src/cdk/v2/destinations/the_trade_desk/utils.js
@@ -28,8 +28,8 @@ const getSignatureHeader = (request, secretKey) => {
   return base;
 };
 
-const responseBuilder = (items, Config) => {
-  const { advertiserId, dataServer } = Config;
+const responseBuilder = (items, config) => {
+  const { advertiserId, dataServer } = config;
 
   const payload = { DataProviderId: DATA_PROVIDER_ID, AdvertiserId: advertiserId, Items: items };
 
@@ -70,12 +70,12 @@ const splitItemsBasedOnMaxSizeInBytes = (items, maxSize) => {
   return batches;
 };
 
-const batchResponseBuilder = (items, Config) => {
+const batchResponseBuilder = (items, config) => {
   const response = [];
   const itemsChunks = splitItemsBasedOnMaxSizeInBytes(items, MAX_REQUEST_SIZE_IN_BYTES);
 
   itemsChunks.forEach((chunk) => {
-    response.push(responseBuilder(chunk, Config));
+    response.push(responseBuilder(chunk, config));
   });
 
   return response;

diff --git a/src/v0/destinations/the_trade_desk/networkHandler.js b/src/v0/destinations/the_trade_desk/networkHandler.js
@@ -10,7 +10,6 @@ const tags = require('../../util/tags');
 const { JSON_MIME_TYPE } = require('../../util/constant');
 
 const proxyRequest = async (request) => {
-  console.log('request', JSON.stringify(request));
   const { endpoint, data, method, params, headers, config } = prepareProxyRequest(request);
 
   if (!config?.advertiserSecretKey) {