chore: map contect key from properties instead of userId

rudderlabs · Feb 22, 2024 · 1c12913 · 1c12913
1 parent b997069
commit 1c12913
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/v0/destinations/sfmc/transform.js b/src/v0/destinations/sfmc/transform.js
@@ -1,3 +1,4 @@
+/* eslint-disable no-param-reassign */
 /* eslint-disable no-nested-ternary */
 const {
   NetworkError,
@@ -182,9 +183,11 @@ const responseBuilderForInsertData = (
   return response;
 };
 
+// DOC : https://developer.salesforce.com/docs/marketing/marketing-cloud/references/mc_rest_interaction/postEvent.html
+
 const responseBuilderForMessageEvent = (message, subDomain, authToken, hashMapEventDefinition) => {
-  const contactKey =
-    getFieldValueFromMessage(message, 'userIdOnly') || getFieldValueFromMessage(message, 'email');
+  const contactKey = message.properties.contactId;
+  delete message.properties.contactId;
   const response = defaultRequestConfig();
   response.method = defaultPostRequestConfig.requestMethod;
   response.endpoint = `https://${subDomain}.${ENDPOINTS.EVENT}`;

diff --git a/src/v0/destinations/sfmc/transform.test.js b/src/v0/destinations/sfmc/transform.test.js
@@ -125,9 +125,10 @@ describe('responseBuilderSimple', () => {
 
   it('should build response object with correct details for message event', () => {
     const message = {
-      userId: '12345',
+      userId: 'u123',
       event: 'testEvent',
       properties: {
+        contactId: '12345',
         prop1: 'value1',
         prop2: 'value2',
       },
@@ -145,13 +146,15 @@ describe('responseBuilderSimple', () => {
       hashMapEventDefinition,
     );
     expect(response.method).toBe('POST');
-    expect(response.endpoint).toBe('https://subdomain.rest.marketingcloudapis.com/interaction/v1/events');
+    expect(response.endpoint).toBe(
+      'https://subdomain.rest.marketingcloudapis.com/interaction/v1/events',
+    );
     expect(response.headers).toEqual({
       'Content-Type': 'application/json',
       Authorization: 'Bearer token',
     });
     expect(response.body.JSON).toEqual({
-      ContactKey: "12345",
+      ContactKey: '12345',
       EventDefinitionKey: 'eventDefinitionKey',
       Data: {
         prop1: 'value1',