refactor: moved transform.js code logic to rtWorkflow

rudderlabs · Feb 1, 2024 · 13fd161 · 13fd161
1 parent 6e12754
commit 13fd161
Show file tree

Hide file tree

Showing 5 changed files with 57 additions and 60 deletions.
diff --git a/src/cdk/v2/destinations/the_trade_desk/rtWorkflow.yaml b/src/cdk/v2/destinations/the_trade_desk/rtWorkflow.yaml
@@ -1,6 +1,14 @@
 bindings:
-  - name: processRouterDest
-    path: ./transform
+  - name: EventType
+    path: ../../../../constants
+  - name: processRecordInputs
+    path: ./transformRecord
+  - name: processConversionInputs
+    path: ./transformConversion
+  - name: handleRtTfSingleEventError
+    path: ../../../../v0/util/index
+  - name: InstrumentationError
+    path: '@rudderstack/integrations-lib'
 
 steps:
   - name: validateConfig
@@ -11,7 +19,30 @@ steps:
       $.assertConfig(config.trackerId, "Tracking Tag ID is not present. Aborting")
       config.ttlInDays ?  $.assertConfig(config.ttlInDays >=0 && config.ttlInDays <= 180, "TTL is out of range. Allowed values are 0 to 180 days")
 
-  - name: processRouterDest
+  - name: validateInput
     template: |
       $.assert(Array.isArray(^) && ^.length > 0, "Invalid event array")
-      $.processRouterDest(^)
+
+  - name: processRecordEvents
+    template: |
+      $.processRecordInputs(^.{.message.type === $.EventType.RECORD}[], ^[0].destination)
+
+  - name: processConversionEvents
+    template: |
+      $.processConversionInputs(^.{.message.type === $.EventType.TRACK}[])
+
+  - name: failOtherEvents
+    template: |
+      const otherEvents = ^.{.message.type !== $.EventType.TRACK && .message.type !== $.EventType.RECORD}[]
+      let failedEvents = otherEvents.map(
+        function(event) {
+        const error = new $.InstrumentationError("Event type " + event.message.type + " is not supported");
+          $.handleRtTfSingleEventError(event, error, {})
+        }
+      )
+
+      failedEvents ?? []
+
+  - name: finalPayload
+    template: |
+      [...$.outputs.processRecordEvents, ...$.outputs.processConversionEvents, ...$.outputs.failOtherEvents]
diff --git a/src/cdk/v2/destinations/the_trade_desk/transform.js b/src/cdk/v2/destinations/the_trade_desk/transform.js
diff --git a/src/cdk/v2/destinations/the_trade_desk/transformConversion.js b/src/cdk/v2/destinations/the_trade_desk/transformConversion.js
@@ -83,6 +83,9 @@ const processEvent = (message, destination) => {
 const process = (event) => processEvent(event.message, event.destination);
 
 const processConversionInputs = async (inputs, reqMetadata) => {
+  if (!inputs || inputs.length === 0) {
+    return [];
+  }
   const respList = await simpleProcessRouterDest(inputs, process, reqMetadata);
   return respList;
 };

diff --git a/src/cdk/v2/destinations/the_trade_desk/transformRecord.js b/src/cdk/v2/destinations/the_trade_desk/transformRecord.js
@@ -46,6 +46,10 @@ const processRecordInputs = (inputs, destination) => {
   const successMetadata = [];
   const errorResponseList = [];
 
+  if (!inputs || inputs.length === 0) {
+    return [];
+  }
+
   if (!Config.audienceId) {
     const segmentNameError = new ConfigurationError(
       'Segment name/Audience ID is not present. Aborting',

diff --git a/test/integrations/destinations/the_trade_desk/router/data.ts b/test/integrations/destinations/the_trade_desk/router/data.ts
@@ -1750,21 +1750,6 @@ export const data = [
               statusCode: 200,
               destination: sampleDestination,
             },
-            {
-              batched: false,
-              metadata: [{ jobId: 3 }],
-              statusCode: 400,
-              error: 'Event type "identify" is not supported',
-              statTags: {
-                errorCategory: 'dataValidation',
-                errorType: 'instrumentation',
-                destType: 'THE_TRADE_DESK',
-                module: 'destination',
-                implementation: 'cdkV2',
-                feature: 'router',
-              },
-              destination: sampleDestination,
-            },
             {
               batchedRequest: {
                 version: '1',
@@ -1803,6 +1788,21 @@ export const data = [
               statusCode: 200,
               destination: sampleDestination,
             },
+            {
+              batched: false,
+              metadata: [{ jobId: 3 }],
+              statusCode: 400,
+              error: 'Event type identify is not supported',
+              statTags: {
+                errorCategory: 'dataValidation',
+                errorType: 'instrumentation',
+                destType: 'THE_TRADE_DESK',
+                module: 'destination',
+                implementation: 'cdkV2',
+                feature: 'router',
+              },
+              destination: sampleDestination,
+            },
           ],
         },
       },