fix: audienceId not found error

rudderlabs · Aug 22, 2024 · 13c5469 · 13c5469
1 parent 018bf23
commit 13c5469
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/v0/destinations/fb_custom_audience/recordTransform.js b/src/v0/destinations/fb_custom_audience/recordTransform.js
@@ -21,7 +21,6 @@ const {
   responseBuilderSimple,
   getDataSource,
 } = require('./util');
-const logger = require('../../../logger');
 
 const processRecordEventArray = (
   recordChunksArray,
@@ -105,7 +104,7 @@ async function processRecordInputs(groupedRecordInputs) {
   const { message } = groupedRecordInputs[0];
   const { isHashRequired, accessToken, disableFormat, type, subType, isRaw, maxUserCount } =
     destination.Config;
-  const audienceId = get(connection, 'Config.destination.audienceId');
+  const audienceId = get(connection, 'config.destination.audienceId');
   const prepareParams = {
     access_token: accessToken,
   };
@@ -117,11 +116,9 @@ async function processRecordInputs(groupedRecordInputs) {
   }
 
   // audience id validation
-  logger.debug('Connection_object', JSON.stringify(connection));
-  logger.debug('Event_object', JSON.stringify(message));
   let operationAudienceId = audienceId;
   const mappedToDestination = get(message, MappedToDestinationKey);
-  if (mappedToDestination) {
+  if (mappedToDestination && !operationAudienceId) {
     const { objectType } = getDestinationExternalIDInfoForRetl(message, 'FB_CUSTOM_AUDIENCE');
     operationAudienceId = objectType;
   }

diff --git a/src/v0/destinations/fb_custom_audience/transform.js b/src/v0/destinations/fb_custom_audience/transform.js
@@ -159,7 +159,7 @@ const processEvent = (message, destination, connection) => {
   let toSendEvents = [];
   let { userSchema } = destination.Config;
   const { isHashRequired, maxUserCount } = destination.Config;
-  const audienceId = get(connection, 'Config.destination.audienceId');
+  const audienceId = get(connection, 'config.destination.audienceId');
   if (!message.type) {
     throw new InstrumentationError('Message Type is not present. Aborting message.');
   }
@@ -248,7 +248,6 @@ const processRouterDest = async (inputs, reqMetadata) => {
   const eventTypes = ['record', 'audiencelist'];
   const unsupportedEventList = checkForUnsupportedEventTypes(groupedInputs, eventTypes);
   if (unsupportedEventList.length > 0) {
-    logger.info(`unsupported events found ${unsupportedEventList}`);
     throw new ConfigurationError('unsupported events present in the event');
   }