fix: wrong base error import in error classes

Signed-off-by: Sai Sankeerth <[email protected]>
rudderlabs · Dec 13, 2023 · 03cdb16 · 03cdb16
1 parent be20850
commit 03cdb16
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 6 deletions.
diff --git a/src/v0/util/errorTypes/filteredEventsError.js b/src/v0/util/errorTypes/filteredEventsError.js
@@ -1,4 +1,4 @@
-const { BaseError } = require('./base');
+const { BaseError } = require('@rudderstack/integrations-lib');
 const { HTTP_STATUS_CODES } = require('../constant');
 
 class FilteredEventsError extends BaseError {

diff --git a/src/v0/util/errorTypes/transformerProxyError.js b/src/v0/util/errorTypes/transformerProxyError.js
@@ -1,5 +1,5 @@
+const { BaseError } = require('@rudderstack/integrations-lib');
 const tags = require('../tags');
-const { BaseError } = require('./base');
 
 const errorTypes = Object.values(tags.ERROR_TYPES);
 const metaTypes = Object.values(tags.METADATA);

diff --git a/src/v0/util/index.js b/src/v0/util/index.js
@@ -83,7 +83,7 @@ const isPrimitive = (arg) => {
 const isNewStatusCodesAccepted = (reqMetadata = {}) => {
   if (reqMetadata && typeof reqMetadata === 'object' && !Array.isArray(reqMetadata)) {
     const { features } = reqMetadata;
-    return !!(features && features[FEATURE_FILTER_CODE]);
+    return !!features?.[FEATURE_FILTER_CODE];
   }
   return false;
 };

diff --git a/src/v0/util/index.test.js b/src/v0/util/index.test.js
@@ -1,5 +1,7 @@
+const { TAG_NAMES } = require('@rudderstack/integrations-lib');
 const utilities = require('.');
 const { getFuncTestData } = require('../../../test/testHelper');
+const { FilteredEventsError } = require('./errorTypes');
 const { hasCircularReference, flattenJson } = require('./index');
 
 // Names of the utility functions to test
@@ -116,3 +118,11 @@ describe('flattenJson', () => {
     );
   });
 });
+
+describe('tests for generateErrorObject', () => {
+  test('test-0', () => {
+    const myErr = new FilteredEventsError('error-1');
+    const outputErrObj = utilities.generateErrorObject(myErr);
+    expect(outputErrObj.statTags).toEqual({});
+  });
+});
diff --git a/test/__tests__/data/braze_router.json b/test/__tests__/data/braze_router.json
@@ -841,9 +841,7 @@
         },
         {
           "error": "[Braze Deduplication]: Duplicate user detected, the user is dropped",
-          "statTags": {
-            "errorCategory": "transformation"
-          },
+          "statTags": {},
           "statusCode": 298,
           "batched": false,
           "metadata": [