Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config for hash to bingads offline conversions #1843

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: add config for hash to bingads offline conversions #1843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28f6e68
feat: add config for hash to bingads offline conversions
ItsSudip Dec 13, 2024
e57492a
Merge branch 'develop' into feat.bingads-offline-conversion
ItsSudip Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/configurations/destinations/bingads_offline_conversions/db-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
"warehouse": ["cloud"]
},
"destConfig": {
"defaultConfig": ["rudderAccountId", "customerAccountId", "customerId"],
"warehouse": [
"connectionMode",
"oneTrustCookieCategories",
"ketchConsentPurposes",
"consentManagement"
]
],
"defaultConfig": ["rudderAccountId", "customerAccountId", "customerId", "isHashRequired"]
}
},
"options": {
Expand Down
4 changes: 4 additions & 0 deletions src/configurations/destinations/bingads_offline_conversions/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^[0-9]+$"
},
"isHashRequired": {
"type": "boolean",
"default": false
},
"oneTrustCookieCategories": {
"type": "object",
"properties": {
Expand Down
32 changes: 32 additions & 0 deletions src/configurations/destinations/bingads_offline_conversions/ui-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,38 @@
"title": "Configuration settings",
"note": "Manage the settings for your destination",
"sections": [
{
"id": "hash",
"title": "Destination settings",
"note": "Configure advanced destination-specific settings here",
"icon": "settings",
"groups": [
{
"title": "Bing ads offline conversion additional settings",
"fields": [
{
"type": "checkbox",
"label": "Enable it, if you are not sending hashed data.",
"note": [
"After enabling this we will send",
{
"text": "hashed email",
"link": "https://learn.microsoft.com/en-us/advertising/bulk-service/offline-conversion?view=bingads-13#hashedemailaddress"
},
"and",
{
"text": "hashed phone numbers",
"link": "https://learn.microsoft.com/en-us/advertising/bulk-service/offline-conversion?view=bingads-13#hashedphonenumber"
},
"to Bingads Offline Conversion."
],
"configKey": "isHashRequired",
"default": false
}
]
}
]
},
{
"id": "consentSettings",
"title": "Consent settings",
Expand Down
3 changes: 3 additions & 0 deletions test/data/validation/destinations/bingads_offline_conversions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@
"config": {
"customerAccountId": "434342324",
"customerId": "447477473",
"isHashRequired": "true",
"oneTrustCookieCategories": {
"warehouse": [
{
Expand All @@ -205,6 +206,7 @@
},
"result": false,
"err": [
"isHashRequired must be boolean",
"oneTrustCookieCategories.warehouse.0.oneTrustCookieCategory must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$\"",
"ketchConsentPurposes.warehouse.0.purpose must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$\""
]
Expand All @@ -213,6 +215,7 @@
"config": {
"customerAccountId": "434342324",
"customerId": "447477473",
"isHashRequired": true,
"oneTrustCookieCategories": {
"warehouse": [
{
Expand Down
Loading