-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean up legacy consent management UI fields #1826
fix: clean up legacy consent management UI fields #1826
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/legacy-cm-ui-cleanup #1826 +/- ##
=============================================================
Coverage 100.00% 100.00%
=============================================================
Files 2 2
Lines 53 53
Branches 7 7
=============================================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
318fcd1
to
0f90a27
Compare
LGTM |
What are the changes introduced in this PR?
The legacy consent management fields in the UI have been removed. The fields are still retained in the schema and db-config files.
I've also fixed consent management field issues in schema and db-config files.
Moreover, I've updated the consent management integrity test suite to catch more such errors in the future.
What is the related Linear task?
https://linear.app/rudderstack/issue/SDK-776/remove-legacy-consent-fields-the-ui-config
Please explain the objectives of your changes below
We don't need legacy consent management fields anymore.
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new checks got introduced or modified in test suites. Please explain the changes.
N/A
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
I have executed schemaGenerator tests and updated schema if needed
Are sensitive fields marked as secret in definition config?
My test cases and placeholders use only masked/sample values for sensitive fields
Is the PR limited to 10 file changes & one task?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.