feat: add config for hash to bingads offline conversions

rudderlabs · Dec 13, 2024 · 28f6e68 · 28f6e68
1 parent 1f4e1c5
commit 28f6e68
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 2 deletions.
diff --git a/src/configurations/destinations/bingads_offline_conversions/db-config.json b/src/configurations/destinations/bingads_offline_conversions/db-config.json
@@ -20,13 +20,13 @@
       "warehouse": ["cloud"]
     },
     "destConfig": {
-      "defaultConfig": ["rudderAccountId", "customerAccountId", "customerId"],
       "warehouse": [
         "connectionMode",
         "oneTrustCookieCategories",
         "ketchConsentPurposes",
         "consentManagement"
-      ]
+      ],
+      "defaultConfig": ["rudderAccountId", "customerAccountId", "customerId", "isHashRequired"]
     }
   },
   "options": {

diff --git a/src/configurations/destinations/bingads_offline_conversions/schema.json b/src/configurations/destinations/bingads_offline_conversions/schema.json
@@ -12,6 +12,10 @@
         "type": "string",
         "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^[0-9]+$"
       },
+      "isHashRequired": {
+        "type": "boolean",
+        "default": false
+      },
       "oneTrustCookieCategories": {
         "type": "object",
         "properties": {

diff --git a/src/configurations/destinations/bingads_offline_conversions/ui-config.json b/src/configurations/destinations/bingads_offline_conversions/ui-config.json
@@ -58,6 +58,38 @@
         "title": "Configuration settings",
         "note": "Manage the settings for your destination",
         "sections": [
+          {
+            "id": "hash",
+            "title": "Destination settings",
+            "note": "Configure advanced destination-specific settings here",
+            "icon": "settings",
+            "groups": [
+              {
+                "title": "Bing ads offline conversion additional settings",
+                "fields": [
+                  {
+                    "type": "checkbox",
+                    "label": "Enable it, if you are not sending hashed data.",
+                    "note": [
+                      "After enabling this we will send",
+                      {
+                        "text": "hashed email",
+                        "link": "https://learn.microsoft.com/en-us/advertising/bulk-service/offline-conversion?view=bingads-13#hashedemailaddress"
+                      },
+                      "and",
+                      {
+                        "text": "hashed phone numbers",
+                        "link": "https://learn.microsoft.com/en-us/advertising/bulk-service/offline-conversion?view=bingads-13#hashedphonenumber"
+                      },
+                      "to Bingads Offline Conversion."
+                    ],
+                    "configKey": "isHashRequired",
+                    "default": false
+                  }
+                ]
+              }
+            ]
+          },
           {
             "id": "consentSettings",
             "title": "Consent settings",

diff --git a/test/data/validation/destinations/bingads_offline_conversions.json b/test/data/validation/destinations/bingads_offline_conversions.json
@@ -182,6 +182,7 @@
     "config": {
       "customerAccountId": "434342324",
       "customerId": "447477473",
+      "isHashRequired": "true",
       "oneTrustCookieCategories": {
         "warehouse": [
           {
@@ -205,6 +206,7 @@
     },
     "result": false,
     "err": [
+      "isHashRequired must be boolean",
       "oneTrustCookieCategories.warehouse.0.oneTrustCookieCategory must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$\"",
       "ketchConsentPurposes.warehouse.0.purpose must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$\""
     ]
@@ -213,6 +215,7 @@
     "config": {
       "customerAccountId": "434342324",
       "customerId": "447477473",
+      "isHashRequired": true,
       "oneTrustCookieCategories": {
         "warehouse": [
           {