Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sprig device mode integration #4

Closed
wants to merge 17 commits into from
Closed

feat: add sprig device mode integration #4

wants to merge 17 commits into from

Conversation

1abhishekpandey
Copy link
Collaborator

@1abhishekpandey 1abhishekpandey commented Oct 17, 2024 •
edited
Loading

Description

  • In this PR we added the Sprig mobile device mode integration.
  • The following event types are supported: identify and track.
  • RESET call is also supported.
  • Rudder-Sprig will be distributed as both CoaoaPod and SPM, as v1.0.0.
  • In order to display the survey, the ViewController instance must be passed before making a track event.
RudderSprigFactory.instance.setViewController(self)
  • The survey looks like this:
    image

@1abhishekpandey 1abhishekpandey self-assigned this Oct 17, 2024
@1abhishekpandey 1abhishekpandey marked this pull request as ready for review October 17, 2024 15:29
SKannaniOS
SKannaniOS reviewed Oct 17, 2024
View reviewed changes
Screenshots/add_rudder_sprig.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Ensure that the screenshot you’re adding to the README displays only the target package, excluding any other packages.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've addressed this comment.

ChryssaAliferi
ChryssaAliferi approved these changes Oct 21, 2024
View reviewed changes
Copy link

@ChryssaAliferi ChryssaAliferi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me

@1abhishekpandey
Copy link
Collaborator Author

1abhishekpandey commented Oct 23, 2024 •
edited
Loading

Release have been made in this PR: #6. Hence closing this.

@1abhishekpandey 1abhishekpandey deleted the feat/sdk-2520-ios-create-sprig-integration-swift-spm-support branch October 23, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SKannaniOS SKannaniOS SKannaniOS approved these changes

@vgupta98 vgupta98 vgupta98 approved these changes

@ChryssaAliferi ChryssaAliferi ChryssaAliferi approved these changes

@arnab-p arnab-p Awaiting requested review from arnab-p

Assignees

@1abhishekpandey 1abhishekpandey

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1abhishekpandey @ChryssaAliferi @vgupta98 @SKannaniOS