Bug 466. Rules without a subscription cannot be listed. Listing rules for an invalid DID causes infinite loading #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MytsV
commented
Aug 29, 2024
Comment on lines
112
to
115
| const data = this.transformResponseModel(responseModel, dto) | ||
| const status = data.status | ||
| if (status === 'success') { | ||
| return data as TResponseModel |
There was a problem hiding this comment.
These are the changes that allow the subscriptions to be optional. Basically, the transformResponseModel function is now responsible for determining whether the postprocessing pipeline element output is optional.
MytsV
commented
Aug 29, 2024
| } | ||
| } | ||
|
|
||
| class OptionalResponsePipelineElement extends BaseStreamingPostProcessingPipelineElement< |
There was a problem hiding this comment.
The test had to be changed to feature different types of pipeline elements, as now they themselves determine error handling
|
TODO: determine if there are any pipeline usecases that need to discard errors |
|
Should the API tests be refactored? Like with utils and fixtures decomposed |
|
Critical/error to handle this |
MytsV
force-pushed
the
bug-466-rules_without_subscription
branch
from
7eb1203
to
db6ea02
Compare
|
@MytsV looks good to go! Could you refactor the pipeline element :) |
…ed behaviour Whether the error is passed on is decided by the implementation of the pipeline element
…over this by a test
…over this by a test
MytsV
force-pushed
the
bug-466-rules_without_subscription
branch
from
db6ea02
to
3534296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #466
Cover this behavior with tests.