Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/signup #4

Merged
merged 10 commits into from
Nov 3, 2023
Merged

F/signup #4

merged 10 commits into from
Nov 3, 2023

Conversation

Yonashenok
Copy link
Collaborator

@Yonashenok Yonashenok commented Nov 2, 2023

summary

i have completed the following implementation

  • created login page
  • created sign up page
  • protected route for auth
  • manage the auth token using React Context

image

here is the back-end PR auth

Copy link
Owner

@rubydevi rubydevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yonashenok,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Linters passed ✔️
  • Sign Up works ✔️
  • Login Works ✔️
  • Great Form Input Validations ✔️
  • Project runs without issue ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Yonashenok Yonashenok merged commit fe2b910 into dev Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants