Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation #38

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Updated documentation #38

merged 4 commits into from
Nov 13, 2023

Conversation

RileyManda
Copy link
Collaborator

@RileyManda RileyManda commented Nov 13, 2023

Implementations

  • Added attribution
  • Added kanban board states to readme
  • Added env file setup
  • Added fe link section
  • Added the additional command for db migration: rails db:migrate RAILS_ENV=test

Front end PR

Kanban board:

Screen Shot 2023-11-13 at 11 17 20 AM

@RileyManda RileyManda requested review from Yonashenok and rubydevi and removed request for Yonashenok and rubydevi November 13, 2023 09:09
Copy link
Owner

@rubydevi rubydevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🥳

Hi @RileyManda 🙋‍♀️
Your PR is COMPLETE! There is nothing else to say other than... it's time to merge it! 🚀 Congratulations!

Highlights 🎯

  • ✅ Professional README
  • ✅ Includes all the requirements.

Cheers and Happy coding!👏👨‍💻💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

@RileyManda RileyManda merged commit 256b212 into dev Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants