Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration file for name column #37

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add migration file for name column #37

merged 1 commit into from
Nov 10, 2023

Conversation

rubydevi
Copy link
Owner

I have added the missing migration file to this PR.

Please review @Yonashenok and I'll merge it to dev.

Copy link
Collaborator

@Yonashenok Yonashenok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🥳

Hi @rubydevi 🙋‍♀️
Your project is COMPLETE! There is nothing else to say other than... it's time to merge it! 🚀 Congratulations!

Highlights 🎯

Excellent execution. Keep up the great work! 👏

  • ✅ migration file is add 👍
  • ✅ propre commit 💯

Cheers and Happy coding!👏👨‍💻💻

suggestions for improvement:

For the next milestone Consider implementing error handling for scenarios where the requested Aeroplane with a specific ID is not found.

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@rubydevi rubydevi merged commit e42cab2 into dev Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants