-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final group capstone #34
Conversation
…d into f/setup-project
Set up Project - Backend
F/models controllers
Feature: Association, Validation and Routing
Added name param to reservations controller
Readme update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Yonashenok,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- Good readme ✔️
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
…from reservations controller
Changes Requested:Readme:correct test command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Yonashenok,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- Tests are now passing✔️
- Readme has been improved ✔️
- Error handling has been implemented✔️
- Superfluous "test" folder has been removed✔️
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
Add migration file for name column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Yonashenok,
Wow, you did it 🎉
Thank you for the changes implemented 💪 🥇 ㊗️
Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩
You are about to finish the Microverse program. You have come a long way!!!
Good luck in the software industry!! I'll see you there. ✨
Congratulations!!!!!! 🎉
To highlight
- Great job✔️
Cheers and Happy coding!👏👏👏
…ban description section
Updated documentation
feature: Readme update
Update readme to include Live URL
Summary
@Yonashenok, @rubydevi and @RileyManda we have completed the implementation of Final group capstone JetLogix's front end is a React application that fetches and displays information from the JetLogix back-end via API endpoints, ensuring a seamless user interface for private jet reservations. Its engaging design delivers an immersive experience, allowing users to efficiently browse, select, and reserve private jets. we have followed the project requirements.
The following tasks have been implemented:
In addition, we have fulfilled the following default requirements:
we will be looking forward to your feedback.
Thank you!
note : after you Run bundle install , Run
rails credential:edit