Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final group capstone #34

Merged
merged 122 commits into from
Nov 16, 2023
Merged

Final group capstone #34

merged 122 commits into from
Nov 16, 2023

Conversation

Yonashenok
Copy link
Collaborator

@Yonashenok Yonashenok commented Nov 9, 2023

Summary

@Yonashenok, @rubydevi and @RileyManda we have completed the implementation of Final group capstone JetLogix's front end is a React application that fetches and displays information from the JetLogix back-end via API endpoints, ensuring a seamless user interface for private jet reservations. Its engaging design delivers an immersive experience, allowing users to efficiently browse, select, and reserve private jets. we have followed the project requirements.


The following tasks have been implemented:

  • Should follow the layout of the provided design.
  • Use different content from the design
  • Select a theme for your website
  • proper authenticated login
  • the navigation panel, the user can see links to
    • Private Planes
    • Reserve
    • My Reservations
    • Add Aeroplane
    • Delete Aeroplane
    • Log Out
  • the main page
    • user can see list of planes and there info
    • user can click the plane and navigate to plane details page
  • the details page
    • user can see more detail info of the plane they selected
    • user can click on reserve button to navigate reservation page
  • When the user clicks the "Add Aeroplane" link in the navigation panel they can see a form for adding a new Aeroplane
  • Make the app responsive, creating both mobile and desktop versions
  • When the user clicks the "Delete aeroplane" link in the navigation panel they can see a list of all aeroplane with title and "Delete" button.
  • When the user clicks the "Delete" button, the selected item is marked as removed and does not show on the main list anymore.
  • To reserve an appointment, the user has to select a date and city (username and selected item are autofilled).
  • To reserve an appointment, the user has to select a date and city (username and selected item are autofilled).
  • Add full documentation for your API
  • Implement proper user authentication from the front-end to the server

In addition, we have fulfilled the following default requirements:

we will be looking forward to your feedback.
Thank you!

note : after you Run bundle install , Run rails credential:edit

rubydevi and others added 30 commits October 31, 2023 18:09
Feature: Association, Validation and Routing
Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yonashenok,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

  • Good readme ✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

You can do it

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.


README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
app/controllers/api/v1/reservations_controller.rb Outdated Show resolved Hide resolved
Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yonashenok,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

  • Tests are now passing✔️
  • Readme has been improved ✔️
  • Error handling has been implemented✔️
  • Superfluous "test" folder has been removed✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

You can do it

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.


.dockerignore Show resolved Hide resolved
Copy link

@Meltrust Meltrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yonashenok,

Wow, you did it 🎉

Brilliant

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

applause

To highlight

  • Great job✔️

Cheers and Happy coding!👏👏👏


@rubydevi rubydevi merged commit 9a804f5 into main Nov 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants