F/show reservations #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubydevi
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Approved 🥳
Hi @RileyManda 🙋♀️
Your project is COMPLETE! There is nothing else to say other than... it's time to merge it! 🚀 Congratulations!
Highlights 🎯
Excellent execution. Keep up the great work! 👏
- ✅ Great work using the right GitHub Flow
- ✅ Good branch name. Great job!
- ✅ Linters are working properly, great job!
- ✅ Properly retrieves the Reservations
Cheers and Happy coding!👏👨💻💻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a minor alteration to the reservations controller to support show reservations#12
Implementations
@rubydevi Please suggest any possible fixes or try it on your end with the json render and without.
Before update:
After update:
Kanban Progress
Please kindly review my implementation.
Front end PR
Thank you 🙏🏻