Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Aeroplanes Index API #22

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Feature: Aeroplanes Index API #22

merged 6 commits into from
Nov 3, 2023

Conversation

rubydevi
Copy link
Owner

@rubydevi rubydevi commented Nov 2, 2023

Description

Exposed API endpoint for aeroplanes index data according to #6

Changes

  • Created a aeroplanes controller action for API
  • Added some data to seed

Kanban Progress

image

Front End PR

rubydevi/jetlogix-frontend#5

@rubydevi rubydevi linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link
Collaborator

@RileyManda RileyManda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢 🟢 🟢

Hi @rubydevi

Your project is complete! There is nothing else to say other than... it's time to merge it: ship it: Congratulations! 🎉

Highlights:

✅ You used Gitflow correctly
✅ The Linter checks passed successfully
✅ APi end points exposure for aeroplanes implemented correctly and accessible.

Screen Shot 2023-11-03 at 1 25 41 PM

Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@rubydevi
Copy link
Owner Author

rubydevi commented Nov 3, 2023

Thanks @RileyManda for the review. I will merge it now.

@rubydevi rubydevi merged commit 72cc8ff into dev Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] Create the main page [Student C]
2 participants