Don't load gem's rbs if rbs_collection.yaml exists #43
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rbs_collection.yaml, some gems can be ignored. ReplTypeCompletor should follow rbs_collection.yaml configuration. When config file exists, additional gem's rbs file shouldn't be loaded.
st0012
approved these changes
Dec 12, 2024
| gem_sig_path = File.expand_path("#{spec.gem_dir}/sig") | ||
| loader.add(library: spec.name, version: spec.version) if Dir.exist?(gem_sig_path) && expanded_sig_path != gem_sig_path | ||
|
|
||
| unless File.exist?('rbs_collection.yaml') |
There was a problem hiding this comment.
I'm not sure if the same principle applies to RBS collection, but when working with dependency declaration files, like Gemfile, it's better to check the lock file's presence too to make sure the project has properly set up the environment.
It will be a very rare case to have users running repl_type_completor with rbs_collection.yaml but without lockfile tho.
ima1zumi
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rbs_collection.yaml, some gems can be ignored.
Ignored gems might have huge/heavy rbs files.
ReplTypeCompletor should follow rbs_collection.yaml configuration. When config file exists, additional gem's rbs file shouldn't be loaded.