Refactor utf-8 strings and invalid strings in test code #800
+364
−372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ima1zumi
reviewed
Jan 5, 2025
| private def convert_str(input, options = {}, normalized = nil) | ||
| return nil if input.nil? | ||
| input = input.chars.map { |c| | ||
| if Reline::Unicode::EscapedChars.include?(c.ord) |
There was a problem hiding this comment.
Reline::Unicode::EscapedChars is no longer use. Could you remove it?
Line 37 in 72c0ec0
~/ghq/github.com/ruby/reline test_rm_invalid_encoding
❯ git grep EscapedChars
lib/reline/unicode.rb: EscapedChars = EscapedPairs.keys.map(&:chr)
There was a problem hiding this comment.
Removed 👍
I also added two more commits that removes \M-[char] from test_within_pipe.rb and from test_rendering.rb
…sed code/arg/options
yamatanooroti handles invalid byte sequence input "\M-[char]" and converts it to "\e[char]" We don't need to use these invalid byte sequence and rely on the hack implemented in yamatanooroti
tompng
force-pushed
the
test_rm_invalid_encoding
branch
from
38300af to
c7b8dac
Compare
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 5, 2025
code (ruby/reline#800) * Remove invalid encoding string "\M-[char]" from test code, remove unused code/arg/options * Omit unicode unnoralized input test in non-utf8 testcase * Remove helper method and constant no longer used in testcode * Change key binding test to use realistic bytes instead of invalid byte sequence * Remove invalid byte sequence input from rendering test yamatanooroti handles invalid byte sequence input "\M-[char]" and converts it to "\e[char]" We don't need to use these invalid byte sequence and rely on the hack implemented in yamatanooroti ruby/reline@f09e7b154c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the problem mentioned in the source code comment in input_keys.
"\M-[char]"should be removed from test code because it is an invalid byte sequence string.Reline only accepts
"\e[char]"which is sent byMeta-[char]key input in modern terminal emulators.After invalid byte sequence are removed, we don't need
convertoption in methodinput_keysbecause valid strings does not need to skip convert.Other changes
def convert_str(input)can be simpler.If the input needs
unicode_normalizebefore conversion, then the prerequisites of the test (input unicode-unnormalized text) are broken. We just need to omit the test if the test encoding is not utf-8.